290916 - TranslateVersionStr doesn't handle missing build ID

Status: RESOLVED WONTFIX

(SeaMonkey :: Installer, defect)

Description

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

My installer (suite) crashes.

My szVersion is "1.8.0." - I guess my build didn't produce a build ID (given the
zeros in the window title, that seems likely).  

  szNum1 = strtok(szVersion, ".");
  szNum2 = strtok(NULL,      ".");
  szNum3 = strtok(NULL,      ".");
  szNum4 = strtok(NULL,      ".");

  vbVersion->ullMajor   = _atoi64(szNum1);
  vbVersion->ullMinor   = _atoi64(szNum2);
  vbVersion->ullRelease = _atoi64(szNum3);
  vbVersion->ullBuild   = _atoi64(szNum4);

Would simply checking for null on szNum4 and setting vbVersion->ullBuild to 0 if
it's null be a valid fix?  Alternately, should the build ID still be specified as 0?

Comment 1

[[e-mail]]

Where's this string being retrieved from?

Comment 2

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

This may be invalid / wontfix due to bug 291014.