290923 - linking of libsimpletest.so fails --with-system-nspr

Status: RESOLVED FIXED

(Toolkit Graveyard :: Build Config, defect, P1)

Description

[Wolfgang Rosenauer [:wolfiR]]

c++ -I/usr/X11R6/include -fno-rtti -fno-exceptions -Wall -Wconversion
-Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy
-Wno-non-virtual-dtor -Wno-long-long -pedantic -O2 -march=i586 -mcpu=i686
-fmessage-length=0 -Wall -Os -fno-strict-aliasing -fshort-wchar -pthread -pipe 
-DNDEBUG -DTRIMMED -O -fPIC -shared -Wl,-h -Wl,libsimpletest.so -o
libsimpletest.so  SimpleTest.o       -lxpcomglue_s -L../../../../../dist/bin
-Wl,-rpath-link,../../../../../dist/bin -lxpcom -lxul  -L../../../../../dist/bin
-L/usr/lib -lplds4 -lplc4 -lnspr4 -lpthread -ldl -Wl,--version-script
-Wl,../../../../../build/unix/gnu-ld-scripts/components-version-script
-Wl,-Bsymbolic -ldl -lm    
/usr/lib/gcc-lib/i586-suse-linux/3.3.5/../../../../i586-suse-linux/bin/ld:
cannot find -lxpcomglue_s
collect2: ld returned 1 exit status

libxpomglue_s.a is only in dist/lib and not in dist/bin.
It can't be found because of this.

Comment 1

[Benjamin Smedberg]

We should be using the new                                                     
                           $(XPCOM_GLUE_LDOPTS) makefile var.

Comment 2

[Darin Fisher]

So, I wonder why the linux tinderbox is green:
http://tinderbox.mozilla.org/showbuilds.cgi?tree=XULRunner

Is there something special about your linux?

Comment 3

[Wolfgang Rosenauer [:wolfiR]]

(In reply to comment #2)
> So, I wonder why the linux tinderbox is green:
> http://tinderbox.mozilla.org/showbuilds.cgi?tree=XULRunner

I can't see enough information about the builds there.
Maybe it's only green because it's no clean build and old files are around?

> Is there something special about your linux?

Don' think so. The linker can't find the archive because there is no
directive to find it in dist/lib. Is libxpcomglue_s.a in dist/bin in your clean
build?

Comment 4

[Wolfgang Rosenauer [:wolfiR]]

don't know what happened in the meantime but now it works for me.

Comment 5

[Wolfgang Rosenauer [:wolfiR]]

hmm, it works usually but it fails if --with-system-nspr is used

Comment 6

[Wolfgang Rosenauer [:wolfiR]]

--- xulrunner/examples/simple/components/src/Makefile.in        22 Apr 2005
13:44:41 -0000      1.3
+++ xulrunner/examples/simple/components/src/Makefile.in        6 Jun 2005
19:45:30 -0000
@@ -52,11 +52,11 @@ IS_COMPONENT        = 1

 CPPSRCS                = SimpleTest.cpp

 # We link against the xpcom glue library to avoid depending on unfrozen
 # XPCOM symbols.
 EXTRA_DSO_LIBS  = xpcomglue_s
-EXTRA_DSO_LDOPTS= $(EXTRA_DSO_LIBS) $(MOZ_COMPONENT_LIBS)
+EXTRA_DSO_LDOPTS= $(EXTRA_DSO_LIBS) $(MOZ_COMPONENT_LIBS) $(LIBS_DIR)

 EXTRA_COMPONENTS= $(srcdir)/SimpleTest.js

 include $(topsrcdir)/config/rules.mk

This patch works but I think there could be another (better) solution.
At least Benjamin recommended another solution.

Comment 7

[Benjamin Smedberg]

This was fixed on 2005-07-25 by bug 299991 to use the correct var.