290967 - removeAttribute doesn't effect the underlying DOM properties

Status: RESOLVED DUPLICATE of bug 320622

(Core :: SVG, defect)

Description

[Harald Albrecht]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050415 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050415 Firefox/1.0+

When removing the transform attribute, for instance, of a rectangle element, the
element's corresponding transformation matrix should be reset to the identity
matrix. However, with the current implementation, the matrix remains unchanged
when the transform attribute is removed.

Reproducible: Always

Steps to Reproduce:
1. Load attached testcase
2. click on the black rectangle

Actual Results:  
The black rectangle stays at its offset at (50,50).

Expected Results:  
The black rectangle should have been moved to the origin at (0,0).

Comment 1

[Harald Albrecht]

Attachment: Shows Gecko not updating the transformation matrix when the transform attribute is removed

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: testcase - removeAttribute on 'fill' and 'transform' attributes

Eek! We aren't going to do much for any SVG attributes (unless they're
intrinsic event attributes). See UnsetAttr for nsSVGElement:

http://lxr.mozilla.org/seamonkey/source/content/svg/content/src/nsSVGElement.cpp#242


Here's another testcase that shows removeAttribute has no affect on the 'fill'
or 'transform' attributes.

Comment 3

[Jonathan Watt [:jwatt]]

Harald, for now just use setAttribute("") as well as removeAttribute. I think
that should have the desired effect, at least most of the time.

Comment 4

[Jonathan Watt [:jwatt]]

*** Bug 302762 has been marked as a duplicate of this bug. ***

Comment 5

[Jonathan Watt [:jwatt]]

We should probably make UnsetAttr first call SetAttr and pass it an empty string
until we figure out something better.

Comment 6

[Holger Will]

unfortunatly the solution from comment #3 does not work in the case of bug#302702

Comment 7

[Jonathan Watt [:jwatt]]

Yeah, and nsSVGViewBox isn't designed to be "unset". If you find any other
attributes that have the same problem, please note them here. Thanks Holger.

Comment 8

[Andreas Neumann]

Attachment: Another testcase to demo that remove attribute on "fill" does not revert to the default value

Comment 10

[Bruce Rindahl]

The attachment from comment #8:
https://bugzilla.mozilla.org/attachment.cgi?id=196132
seems to be working now in the latest nightly but the attachment:
https://bugzilla.mozilla.org/attachment.cgi?id=269416
from the duplicate bug 385499 shows that removeAttributeNS(null,"transform") doesn't work.
Sorry about the duplicate bug!