291048 - Empty cells in show_activity.cgi when removed/added is zero

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Teemu Mannermaa (:wicked)]

If removed or added column in show_active.cgi consists of only a zero the field
is displayed as a blank. This same problem was fixed in bug 92713 (2001-07-30)
but was probably regressed again when show_active.cgi was templatized in bug
117760 (2002-04-03). This happens atleast when everconfirmed is changed from 0 to 1.

One probably needs to change template/en/default/bug/activity/table.html.tmpl
file around line 78. This is assuming template directive like [% IF
change.removed %] thinks zeros shouldn't be displayed.

Comment 1

[Olav Vitters]

Confirming just to test the bug

Comment 2

[Olav Vitters]

Indeed, taking.

Comment 3

[Olav Vitters]

Attachment: Patch v1, current 2.22 cvs. applies to 2.20 cleanly.

Very simple. tested. changed change.added to use .defined as well.

Comment 4

[Frédéric Buclin]

Comment on attachment 205576 [details] [diff] [review]
Patch v1, current 2.22 cvs. applies to 2.20 cleanly.

r=LpSolit for tip and 2.20.

Comment 5

[Frédéric Buclin]

tip:

Checking in template/en/default/bug/activity/table.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/activity/table.html.tmpl,v  <--  table.html.tmpl
new revision: 1.10; previous revision: 1.9
done

2.20:

Checking in template/en/default/bug/activity/table.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/activity/table.html.tmpl,v  <--  table.html.tmpl
new revision: 1.9.2.1; previous revision: 1.9
done