291071 - Dialog to set Firefox as default browser confused screen reader

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

When a screen reader user launches Firefox for the first time, they encounter
the default browser dialog.

This dialog confuses the screen reader and causes quirky behavior right off the
bat, because an accessible focus event is fired for the dialog itself, but not
any control within it.

Comment 1

[Aaron Leventhal]

Attachment: Make sure initial focus is fired correctly

Comment 2

[[e-mail]]

Comment on attachment 183823 [details] [diff] [review]
Make sure initial focus is fired correctly

Why do you need to overload the meaning of FlushPendingEvents, rather than
using a new callback to call FireCurrentFocusEvent?

Comment 3

[Aaron Leventhal]

(In reply to comment #2)
> (From update of attachment 183823 [details] [diff] [review] [edit])
> Why do you need to overload the meaning of FlushPendingEvents, rather than
> using a new callback to call FireCurrentFocusEvent?
> 

I just figured it is an event that needs to be flushed with the rest, and I
didn't need to add as many new member variables and methods. It didn't seem too
unclean to me. Want me to change it?

Oops, not FIXED.

Comment 4

[[e-mail]]

I can't be sure that the way you have it now won't conflict with something else.
Besides, you'll actually save a member variable my way - all your new callback
will do is cast its closure so it can call FireCurrentFocusEvent on it.

Comment 5

[Aaron Leventhal]

Attachment: Separate timer and callback to fire current focus event

Comment 6

[Aaron Leventhal]

Attachment: Also fix case where page loads too fast, don't fire doc loaded events unless page is focused (not the case when dialog open) -- wait til timeout to look at focus

Requesting another review from Neil for the
nsDocAccessibleWrap.cpp/nsAccessibilityService.cpp changes -- the rest is the
same as before.

Comment 7

[[e-mail]]

Comment on attachment 184162 [details] [diff] [review]
Also fix case where page loads too fast, don't fire doc loaded events unless page is focused (not the case when dialog open) -- wait til timeout to look at focus

>+    nsCOMPtr<nsISupports> container = doc->GetContainer();
>+    nsCOMPtr<nsIDocShell> docShell = do_QueryInterface(container);
Nit: you can shorten this to
nsCOMPtr<nsIDocShell> docShell = do_QueryInterface(doc->GetContainer());

Comment 8

[Aaron Leventhal]

(In reply to comment #7)
> Nit: you can shorten this to
> nsCOMPtr<nsIDocShell> docShell = do_QueryInterface(doc->GetContainer());
> 

Done.

Comment 9

[Mike Shaver (:shaver emeritus)]

Comment on attachment 184162 [details] [diff] [review]
Also fix case where page loads too fast, don't fire doc loaded events unless page is focused (not the case when dialog open) -- wait til timeout to look at focus

a=shaver for 1.8b3 (not a front-end change)

Comment 10

[Aaron Leventhal]

Checking in src/base/nsAccessibilityService.cpp;
/cvsroot/mozilla/accessible/src/base/nsAccessibilityService.cpp,v  <-- 
nsAccessibilityService.cpp
new revision: 1.142; previous revision: 1.141
done
Checking in src/base/nsDocAccessible.h;
/cvsroot/mozilla/accessible/src/base/nsDocAccessible.h,v  <--  nsDocAccessible.h
new revision: 1.26; previous revision: 1.25
done
Checking in src/base/nsRootAccessible.cpp;
/cvsroot/mozilla/accessible/src/base/nsRootAccessible.cpp,v  <-- 
nsRootAccessible.cpp
new revision: 1.119; previous revision: 1.118
done
Checking in src/base/nsRootAccessible.h;
/cvsroot/mozilla/accessible/src/base/nsRootAccessible.h,v  <--  nsRootAccessible.h
new revision: 1.48; previous revision: 1.47
done
Checking in src/msaa/nsDocAccessibleWrap.cpp;
/cvsroot/mozilla/accessible/src/msaa/nsDocAccessibleWrap.cpp,v  <-- 
nsDocAccessibleWrap.cpp
new revision: 1.28; previous revision: 1.27
done