291073 - Don't allow localization of command keys

Status: RESOLVED WONTFIX

(Core :: Internationalization: Localization, defect)

Description

[Aaron Leventhal]

This is a spin off from bug 279245 and a newsgroup discussion thread.

Ctrl/cmd global command keys should never change based on
the localization. The consensus in the newsgroup discussion was we should take
these out of the localization files to prevent future accidental localization of
those keys, as what caused bug 279245.

Here's the newsgroup thread:
http://groups-beta.google.com/group/netscape.public.mozilla.l10n/browse_thread/thread/df3affe36bd789aa/6e9299729a4dd42d?q=279245+mozilla&_done=%2Fgroups%3Fq%3D279245+mozilla%26qt_s%3DSearch+Groups%26&_doneTitle=Back+to+Search&&d#6e9299729a4dd42d

Comment 1

[Stefan [:stefanh]]

There are certain cases when "accel+letter" is necessary to localize. On mac
Firefox uses Cmd+[ and Cmd+] for back and forward. However, on a Swedish (and
probably Danish/Norwegian etc) keyboard you have to press Alt+8 in order to
produce a "[".

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

not AltGr+8?

Comment 3

[Robert Kaiser]

(In reply to comment #1)
> There are certain cases when "accel+letter" is necessary to localize. On mac
> Firefox uses Cmd+[ and Cmd+] for back and forward. However, on a Swedish (and
> probably Danish/Norwegian etc) keyboard you have to press Alt+8 in order to
> produce a "[".

Can you localize that with our current infrastructure?

Anyways, IMHO, we should ideally go into a direction that allows customization
of command keys, so that we fit in with other software that supports that.

Comment 4

[u60234]

(In reply to comment #3)
> Can you localize that with our current infrastructure?

Yes, we have both goBackCmd.commandKey and goForwardCmd.commandKey that we can
localize.

Comment 5

[Robert Kaiser]

(In reply to comment #4)
> Yes, we have both goBackCmd.commandKey and goForwardCmd.commandKey that we can
> localize.

I know, but can you set it to Alt+8 so that it triggers Cmd+[ (Cmd+Alt+8) then?

Comment 6

[u60234]

I don't think so, but who would want such an awkward combination. And we can't
use keycodes such as VK_LEFT. We could use the letters "Ö" and "Ä" though.

 

Comment 7

[Stefan [:stefanh]]

 
> I know, but can you set it to Alt+8 so that it triggers Cmd+[ (Cmd+Alt+8) then?

Since [ and ] isn't even displayed on my keyboard (apple standard one) we better
use our "own". Even Safari uses locale-specific keys instead of [ and ]

Comment 8

[Martin Creutziger [:MMx]]

(In reply to comment #7)

> Since [ and ] isn't even displayed on my keyboard (apple standard one) we better
> use our "own". Even Safari uses locale-specific keys instead of [ and ]

Same is true for German Mac keyboards btw. 
And no, biesi, there is no "AltGr" on Mac.

Comment 9

[timeless]

for the most part you shouldn't need altgr on macs, we have option which is used
for extra characters.