Closed Bug 291086 Opened 20 years ago Closed 20 years ago

Can't build --enable-cairo and --enable-svg-renderer-cairo (canvas problem)

Categories

(Firefox Build System :: General, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 290835

People

(Reporter: roc, Assigned: roc)

Details

Attachments

(1 file)

layout/build/Makefile.in contains:

ifdef MOZ_ENABLE_CAIRO
# don't add twice
ifndef MOZ_SVG_RENDERER_CAIRO
EXTRA_DSO_LDOPTS += $(MOZ_CAIRO_LIBS) \
                    $(NULL)
endif
endif

But, I can't see where we add MOZ_CAIRO_LIBS if MOZ_SVG_RENDERER_CAIRO is
enabled. In fact we don't, because builds so configured crash whenever you try
to use canvas: "undefined symbol: cairo_create".
Attached patch fixSplinter Review
unconditionally add the cairo libs if Cairo is enabled in the build.
Attachment #181244 - Flags: superreview?(bryner)
Attachment #181244 - Flags: review?(bryner)
Comment on attachment 181244 [details] [diff] [review]
fix

this might be invalid. Let me build a new tree.
Attachment #181244 - Flags: superreview?(bryner)
Attachment #181244 - Flags: review?(bryner)
See the patch on bug 290835.

*** This bug has been marked as a duplicate of 290835 ***
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → DUPLICATE
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: