291101 - Include reason for denial on itemoverview

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[alanjstr]

/developers/itemoverview.php

When an extension is denied, an email is sent to the developer.  The text is
also retained in the approval table.  However, tracking these down could be
easier.  On the item overview, where it says "Denied", we should display why. 
To avoid a lot of extra coding, the easiest thing would be to set the "release
notes" of that version to be the reason why at the same time we're setting the
Denied flag.

Comment 1

[Colin Ogilvie [:cso]]

I'd acutally like to see itemoverview expanded to include:

1) Date Uploaded
2) Date Approved / Denied
3) Reason for Denial if necessary

Comment 2

[Michael Morgan [:morgamic]]

Mass change - bugs to be read / (re)confirmed.

Comment 3

[Cameron]

AMO bugspam. Correcting QA contacts on OLD bugs ([e-mail])

-> Correct QA contact ([e-mail])

Filtermeplzkthx

Comment 4

[Cameron]

I'm duping this forward, even though they're slightly different, I think that Bug 335373 is a better solution for this. 

*** This bug has been marked as a duplicate of 335373 ***

Comment 5

[Justin Scott [:fligtar]]

Due to bug 350187, authors are not currently getting the approval/denial emails from AMO, so they have no way of finding out why their add-on was denied. Reopening and working on a patch now.

Comment 6

[Justin Scott [:fligtar]]

Attachment: patch for developer item history

Instead of adding the approval comments, which in some cases are quite long, to the item overview page, I just gave developers access to the Item History page for reviewers for their own add-ons. Only reviewers and admins can see the reviewers' email addresses, however.

Also, I discovered a bug with the list of versions in itemoverview.php. It uses a group by URI because there are multiple rows for each version, however when an addon is denied, the URI field is cleared. This means that only one denied version will ever be displayed in the list. I changed the group by to by OSName and Version so that all versions are shown.

Comment 7

[Michael Morgan [:morgamic]]

These two fixes improve the pages quite a bit -- it looked good.  They should be checked in.  Working on an IT req.