Closed
Bug 291106
Opened 20 years ago
Closed 19 years ago
installer bails with garbage dialog if installing the last component had an error
Categories
(Firefox :: Installer, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: ajschult784, Assigned: ajschult784)
Details
Attachments
(1 file)
|
2.16 KB,
patch
|
bryner
:
review+
|
Details | Diff | Splinter Review |
If the last component installed has an error, nsXIEngine::Install will return E_INSTALL. nsInstallDlg::PerformInstall does XI_ERR_BAIL, which calls ErrorHandler(E_INSTALL), but ErrorHandler expects a second argument with E_INSTALL. |msg| is used uninitialized, resulting in a garbage dialog.
|
Assignee | |
Comment 1•20 years ago
|
||
Prevent the dialog and print a message with %s in the case this happens some other way. A toolkit version of bug 261567 would also fix this.
Attachment #181251 -
Flags: review?(bryner)
|
||
Updated•19 years ago
|
QA Contact: bugzilla → installer
|
||
Updated•19 years ago
|
Attachment #181251 -
Flags: review?(bryner) → review+
|
|
Assignee | |
Comment 2•19 years ago
|
||
fixed
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•