291149 - Events don't have a msg property set, making them hard to match in hook patterns

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[:Gijs (out for now; he/him)]

Currently, ChatZilla does not store the contents of PRIVMSG or NOTICE messages
on an event. This would be very useful when hooking specific kinds of messages.
Right now, someone who would want to do that has no choice but to hook *all*
PRIVMSG or NOTICE messages and match the message later on, or use complicated
lambda functions.

I believe minimal modifications should make it possible to store the message in
e.msg to make it available for matching by hook patterns.

Comment 1

[:Gijs (out for now; he/him)]

Attachment: Patch v1

Patch to add e.msg in onNotice and onPrivmsg. We can't do it earlier because we
are not sure of the target (and thus not sure of the character encoding we
should use)

Comment 2

[James Ross]

Comment on attachment 181295 [details] [diff] [review]
Patch v1

>Index: mozilla/extensions/irc/js/lib/irc.js

>+    e.msg = e.decodeParam(2, e[e.set]);

Is there something wrong with e.replyTo as the 2nd param? :)


>     else
>         e.destObject = e.replyTo;
> 
>+    if (e.set != "server")
>+        e.msg = e.decodeParam(2, e[e.set]);

Why not put it in the else part above?

Comment 3

[:Gijs (out for now; he/him)]

Attachment: Patch v2

Maybe next time I ought to not give the patch a version number. It sparks off
the wrong ideas ;-).

Comment 4

[James Ross]

Comment on attachment 181298 [details] [diff] [review]
Patch v2

r=[e-mail]

Comment 5

[Asa Dotzler [:asa]]

Comment on attachment 181298 [details] [diff] [review]
Patch v2

a=asa

Comment 6

[James Ross]

Checked in --> FIXED.

Automated builds at http://twpol.dyndns.org/mozilla/chatzilla/nightly/ will
include this shortly.