291160 - breadcrumb extension seems to break if there's a slash in a page name

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: General, defect)

Description

[Deb Richardson [:dria] (plz NEEDINFO)]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.7) Gecko/20050414 Firefox/1.0.3 StumbleUpon/1.9994
Build Identifier: 

Example:
http://developer-test.mozilla.org/docs/DHTML_Demonstrations_Using_DOM/Style:Stock_Ticker

The problem there is the root "Home" element...it's not pointing in the correct
location.


Reproducible: Always

Comment 1

[Mike Shaver (:shaver emeritus)]

So the problem here is that I just emit a link directly, instead of having the
wiki parser find the right link for me.  I'd _thought_ that
$parent_title->getLocalURL() would do the right thing for me there, but clearly
I was not correct.  You might say that I was wrong, even.

Maybe I should just start emitting wikitext for the breadcrumbs, and popping
through the parser again.  That sounds like pain, but it might be the most
robust thing to do.

Comment 2

[Jeff Walden [:Waldo]]

Changing QA contact to the default QA so interested parties can watch bugs filed
before the default QA was changed.  Only bugs in an unfixed state have been
changed; fixed bugs are unlikely to be reopened, and more bugspam is always a
bad thing.  Sorry for the bugspam - filter it into your Junk folder by searching
for 'WhyDoesMediaWikiHaveToBeEvilAndNotAcceptArbitraryCharactersInTitlesAndLinks'.

Comment 3

[Deb Richardson [:dria] (plz NEEDINFO)]

Just upgrading this a little bit because the XSLT/XPath Reference navigation is
currently broken.  If this isn't going to be fixed soonish, I'll move the pages
so they no longer have a slash in the name.  Just let me know.

Comment 4

[Mike Shaver (:shaver emeritus)]

Fixed by revision 1.3 of Breadcrumbs.php, turning over to polvi for update of
extension.

Comment 5

[Mike Shaver (:shaver emeritus)]

Fixed by revision 1.3 of Breadcrumbs.php, turning over to polvi for update of
extension.

Comment 6

[Mike Shaver (:shaver emeritus)]

Sigh, reopening so it shows up for Alex.  I'm such a noob.

Comment 7

[Alex Polvi]

I applied the patch and it broke all of the developer wikis. 

Parse error: parse error, unexpected T_OBJECT_OPERATOR in
/data/devmo-dev/ca/docs/extensions/mozilla-extensions/Breadcrumbs.php on line 69

Comment 8

[Alex Polvi]

fixed and installed.