291209 - Allow Relative Date Searches by Hour

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, enhancement)

Description

[Justin Wood (:Callek)]

When running a query based on relative dates, searching based on relative hours
should also be possible.

Comment 1

[Justin Wood (:Callek)]

Attachment: Described Patch, to cvs-tip

I opted for beginning of hour, to stay consistant with other relative search's,
(even though what I really wanted was exactly foo-hours ago.

Is this enough for Bugzilla Stable? (as in if I was to get justdave to update
bmo with this, or do I need to checkout a branch)

Comment 2

[Justin Wood (:Callek)]

Comment on attachment 181340 [details] [diff] [review]
Described Patch, to cvs-tip

sorry for tabs, I can provide a non-tabify patch later if you like.

Comment 3

[Justin Wood (:Callek)]

Attachment: v2 to tip

Noticed a mistake in the edited help file...and fixed tabs this time.

Comment 4

[Joel Peshkin]

I'm not sure if I prefer hours being relative to the beginning of an hour or
simply being 60 minutes.  I'd opt for 60 minutes which would mean...

Hour - relative to now
Day - relative to midnight
Week - 7 days
Month - relative to first of month
Year - relative to first of year

Comment 5

[Justin Wood (:Callek)]

Attachment: v3

As descussed on IRC, \dh will now be equal to $1*60 minutes;  though if the
number is 0, will match current behavior.

Comment 6

[Joel Peshkin]

Comment on attachment 181502 [details] [diff] [review]
v3

+	     # Special case 0h for 'beginning of this hour'
+	     if ($amount == 0;) {

oops... wont compile

Comment 7

[Justin Wood (:Callek)]

Attachment: v3.1

sorry about that

Comment 8

[Dave Miller [:justdave]]

holding approval until we branch.  I've had requests for this though, so I might
consider applying it to bmo before then if I get a chance to test it on the
backup installation.

Comment 9

[Frédéric Buclin]

Checking in Bugzilla/Search.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search.pm,v  <--  Search.pm
new revision: 1.100; previous revision: 1.99
done
Checking in template/en/default/search/search-help.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/search-help.html.tmpl,v
 <--  search-help.html.tmpl
new revision: 1.6; previous revision: 1.5
done

Comment 10

[Frédéric Buclin]

*** Bug 301344 has been marked as a duplicate of this bug. ***

Comment 11

[Albert Ting]

(In reply to comment #10)
> *** Bug 301344 has been marked as a duplicate of this bug. ***

I know it's late, but can this also be part of 2.20?  With the new whine.pl
feature, searching based on relative hours becomes a lot more useful (such as
auto-notifying unattended critical bugs). 

Comment 12

[Gervase Markham [:gerv]]

Dave: any chance we can get this on b.m.o.? See bug 54330.

Gerv

Comment 13

[Max Kanat-Alexander]

Added to the Bugzilla 2.22 Release Notes in bug 322960.