291232 - update installer packages should offer unchecked check box for setting start page

Status: VERIFIED FIXED

(Toolkit :: Application Update, defect)

Description

[Asa Dotzler [:asa]]

For the windows update packages, we want to uncheck the box for setting the
default home page. This is necessary because we currently give Windows users an
update that is the full install wizard rather than a silent install package. 

The bug about doing the right thing with our installer in all normal cases is
bug 263595. This bug will be resolved when we've patched the 1.0.x update
packages to do something better. We won't be making changes to the regular
installer on the branch or on the trunk, except as work from bug 263595.

Comment 1

[Chase Phillips]

Asa, this doesn't match my understanding of our intent based on the meeting.  On
the branch, we won't be making builds we release for update that contain
separate changes from the builds we release for regular installation.  That's by
design due to the amount of work involved (in setting up the builds, taking and
testing the change, then diverging the builds we send to the different
audiences, introducing even more testing headaches).

We should ask for a change on the branch that adds support to the installer for
a flag which can be passed in (a la '-ira') by update.xpi's install.js invoking
the functionality you want to be different based on whether or not the build is
being used in the form of an update.

A new bug needs to be filed on the installer (and someone who works on that code
should be the assignee) to add support for that flag on the branch.

I'm moving this bug to Software Update so it can focus on tracking the work
necessary to add the flag to our invocation of the installer in install.js.

Comment 2

[Benjamin Smedberg]

Why don't we do something simple, like "if you're upgrading an existing install
(which the installer already detects), don't check by default, otherwise do"?

This is extraordinarily simple to code, and prevents us having multiple packages
or even special flags floating around.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #2)
> Why don't we do something simple, like "if you're upgrading an existing install
> (which the installer already detects), don't check by default, otherwise do"?

Based on bug 263595 comment 27, I would just remove the box entirely. Surely
that's the simplest solution. The only time it ever has any effect is if you're
updating, or if you're migrating profile data from a browser other than IE. I
think the chance of people wanting their homepage resest when they've already
specified one (either in FF or in the browser they're importing from) is pretty
slim.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Mike Connor removed the checkbox for Deer Park, I believe the intention was to
never put it back.

Comment 5

[Chase Phillips]

There's probably a better owner for this bug besides me.

Comment 6

[Jay Patel [:jay]]

Chase:  Can you find an owner for this bug (maybe mconnner?).  

We should get a patch ready to checkin for 1.0.5 (if we indeed still think we
want this in).  Asa?

Comment 7

[Asa Dotzler [:asa]]

Mike, can you help us out here in prep for a potential 1.0.5 release?

Comment 8

[Mike Connor [:mconnor]]

No problem, I'm assuming we just want to uncheck the box, and not remove it
entirely a la trunk?

Comment 9

[Jay Patel [:jay]]

Mike:  Yes, for the Aviary branch let's just uncheck the box.  Thanks.

Comment 10

[Jay Patel [:jay]]

Mike: Will you be able to get this fix in soon?  I noticed you reassigned it to
noboby.  If you can't put together a patch, let us know so we can find someone
else to get this in for 1.0.5.  Thanks.

Comment 11

[:Gavin Sharp [email: [e-mail]]]

Correcting email address, Mike, see comment from Jay above.

Comment 12

[Mike Connor [:mconnor]]

Hmm, that's weird, I must have hit the reassign to defaults by mistake.

I should have a patch for this tonight, my aviary build dies at the end, but the
installer still builds, so we're all good.

Comment 13

[Mike Connor [:mconnor]]

Attachment: flip the switch

Comment 14

[Daniel Veditz [:dveditz]]

Comment on attachment 186202 [details] [diff] [review]
flip the switch

r=dveditz

Comment 15

[Daniel Veditz [:dveditz]]

Comment on attachment 186202 [details] [diff] [review]
flip the switch

a=dveditz per drivers mtg

Comment 16

[Tracy Walker [:tracy]]

verified fixed on Windows 1.0.5 branch build 2005-06-16-04-aviary1.0.1