Closed Bug 29124 Opened 25 years ago Closed 25 years ago

Mail Password dialog should say "Remember password" not "Save this value"

Categories

(SeaMonkey :: MailNews: Message Display, defect, P3)

Product:
SeaMonkey
Component:
MailNews: Message Display
Platform:
x86
Windows 98
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: jglick, Assigned: bugs)

Details

(Keywords: polish, Whiteboard: [PDT-] [nsbeta3+])

The Mail Password dialog currently has a checkbox that says "Save this value". This saves the user's password. The wording should be "Remember password". Users will potentially see this dialog everytime they launch Mail or attempt to authenticate to a server. "Save this value" is to techy and potentially confusing. 4.7 uses "Remember password".
Nominate as B1.
Keywords: beta1
Putting on PDT- radar for beta1.
Whiteboard: [PDT-]
I think ben@netscape.com owns the UI for this
Assignee: phil → ben
Ben, move this off post beta 2 if you're swamped.
Target Milestone: --- → M16
QA Contact: lchiang → nbaca
OK, I believe the official wording is now "Save my password".
Target Milestone: M16 → M17
M20.
Target Milestone: M17 → M20
Doesn't M20 mean this is out of the product? I think it should be part of UI clean up, M18/M19?
I agree with Jennifer. It really looks quite nerdy to have this text string the way it is. I recommend we change it ASAP.
Keywords: beta1 → nsbeta3
Placing "nsbeta3" in Keywords so its reviewed again.
Vera, is this still a valid bug? I believe it is taken care of already??
I don't know what text the dialog currently displays, but I will be re-reviewing all the UI text for Password Manager (and all the other browser features) for beta 3.
Keywords: polish
Whiteboard: [PDT-] → [PDT-] [b3nav+]
nav triage team: [b3nav+] now = [nsbeta3+]
Whiteboard: [PDT-] [b3nav+] → [PDT-] [nsbeta3+]
This dialog now says "Use Password Manager to remember this value" Is this still a problem? Reads ok to me.
Status: NEW → ASSIGNED
The thought was that using the term "value" was sorta techie and should be changed. Vera, this one is your call. Please provide the text you would recommend.
Please change it to "Use Password Manager to remember this password."
This is not specific to mailnews. This is a generic single signon string. I imagine mailnews is relying on singsign to put up this dialog, and singsign has control over what gets displayed. I'm not familiar with the usage of these text strings, whether they're always specific to passwords (and thus could be changed in the general case in the appropriate properties file for single signon), or if mailnews is a special case and there needs to be a way for mail to provide wallet with such a strings. The latter case sounds like an awful lot of work, in mailnews and single signon code. cc'ing Steve Morse as he may wish to comment.
There are two API's that single-signon provides -- one to save a password and one to save an arbitrary piece of data (typically the user name). The save-password is by far the more common one. In fact the other is used in one specific case -- namely in news for some obscure reason that I never understood. Problem is that both of these are implemented using the same string. So the change here would be to add a new string in wallet.properties so that each API uses it's own string. Then you could have the save-password routine put up its customized string of "remember this password" and have the other routine continue to use the nebulous "remember this value" string. Frankly I think it's not worth the effort, but if you really want the change it can be done.
I don't think we need separate strings, I just though the wording "save this value" was a little technie and that Vera might have a better wording suggestion.
Steve, would the two places in singsign.cpp that use this value be (according to LXR) lines 457 (in si_CheckGetData) and 396 (in si_CheckGetPassword)? If my assumption is correct, all I'd have to do is add a new string to wallet.properties and update the usage in si_CheckGetPassword to use the new string... If this is all that needs to be done I can produce a patch.
my line numbers are valid for the encrypted string, the obscured string are off by 2 ;) Either way I'd be adding two strings, one for encrypted and one for obscured.
Yes, that's exactly what the change entails. I never said it was difficult, just that it wasn't worth the effort. But if you want to make the change, send it to me for a code review.
BTW, I just came across some previous comments of mine on this very topic. Take a look at bug report 27994, specifically my comments of 2000-02-17 09:08. It's interesting to reread that now in light of this report.
Adding myself to cc: list.
I really doubt that someone reading this line would understand that value=password (or values=username and password). If at all possible, I'd like the message to state exactly what's being saved, for the sake of clarity.
I fixed this.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Build 2000-09-21-12M18: NT4 Build 2000-09-21-04M18: Mac 9.04 Build 2000-09-21-10M18: Linux 6.0 Verified Fixed. It now states "Use Password Manager to remember this password".
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.