Closed Bug 291276 Opened 15 years ago Closed 15 years ago

[Mac] don't force edit commandsets from macBrowserOverlay

Categories

(Firefox :: Menus, defect, P2)

PowerPC
macOS
defect

Tracking

()

RESOLVED FIXED
Firefox1.5

People

(Reporter: mano, Assigned: mano)

Details

(Keywords: regression)

Attachments

(1 file)

The edit command sets from browser-sets.inc has no real value for
macBrowserOverlay, they can either do nothing in the overlayed windows or break
their own edit commands.

The attached fix:
 1) Restores JS Console's copy error command (it'll also work from the edit menu).
 2) Allow windows like the download manger to provide their own edit menu
commandsets.
 3) For windows which don't provide their own edit command sets, disable the
edit menu items.
Attached patch patchSplinter Review
Assignee: firefox → bugs.mano
Status: NEW → ASSIGNED
Attachment #181399 - Flags: review?(mconnor)
Attachment #181399 - Flags: review?(mconnor) → review+
Priority: -- → P2
Target Milestone: --- → Firefox1.1
Comment on attachment 181399 [details] [diff] [review]
patch

a=asa
Attachment #181399 - Flags: approval-aviary1.1a? → approval-aviary1.1a+
Checking in base/content/browserMountPoints.inc;
/cvsroot/mozilla/browser/base/content/browserMountPoints.inc,v  <-- 
browserMountPoints.inc
new revision: 1.2; previous revision: 1.1
done
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
QA Contact: bugzilla → menus
You need to log in before you can comment on or make changes to this bug.