Closed Bug 291296 Opened 20 years ago Closed 20 years ago

lxr renders '0' as '' in page

Categories

(Webtools Graveyard :: MXR, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 18587

People

(Reporter: ian, Assigned: chase)

Details

Correct me if I'm wrong, but this part in nsHTMLCanvasElement.cpp:

291     // check that ctxId is clamped to A-Za-z0-9_-
292     for (PRUint32 i = 0; i < ctxId.Length(); i++) {
293       if ((ctxId[i] < 'A' || ctxId[i] > 'Z') &&
294           (ctxId[i] < 'a' || ctxId[i] > 'z') &&
295           (ctxId[i] < '' || ctxId[i] > '9') &&
296           (ctxId[i] != '-') &&
297           (ctxId[i] != '_'))
298       {
299         return NS_ERROR_INVALID_ARG;
300       }
301     }

...seems wrong. Specifically, the third line of the |if| statement should have
|'0'| not |''|.
Is this coming from lxr or from a local checkout?  That seems like some sort of
file horkage, since what's coming from CVS is definitely '0' ('' wouldn't even
compile, I don't think).
lxr.
yeah, lxr bug.. crazy.
Assignee: vladimir → justdave
Component: Layout: Misc Code → Server Operations
Product: Core → mozilla.org
QA Contact: layout.misc-code → myk
Summary: Incorrect check for getContext() argument → lxr renders '0' as '' in page
Version: Trunk → other
Assignee: justdave → chase
Component: Server Operations → LXR
OS: Windows XP → All
Product: mozilla.org → Webtools
QA Contact: myk → timeless
Hardware: PC → All

*** This bug has been marked as a duplicate of 18587 ***
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → DUPLICATE
QA Contact: timeless → lxr
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.