291343 - moving single grouped message makes another group disappear

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Daniel Steinbrook]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.7) Gecko/20050414 Firefox/1.0.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.7) Gecko/20050418 Thunderbird/1.0.2

When moving a message from a folder sorted in groups when it is the only message
in that group, the next grouped category disappears until the folder is refreshed.

Reproducible: Always

Steps to Reproduce:
1. Sort a folder's messages in groups; make sure one message is in its own group.
2. Move the single message, thus removing its group.
Actual Results:  
Two groups of messages disappeared -- the one that should disappear, and the
next group down.

Expected Results:  
Only the deleted/moved message's group should disappear.

Comment 1

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/

Comment 2

[Stefan Blobner]

I can confirm this bug in Thunderbird 1.5 Beta 2:

how to reproduce: in the Inbox, have 5 messages sorted by date and grouped by
sort. one in 'old mail', three in 'yesterday' and one in 'today. now I move the
one message from 'old mail' into Trash by drap&drop using the mouse. afterwards
the 'old mail' disappeard (ok) and the 'Today' is still there but the message is
not displayed any more until I switch to another folder and back to the Inbox.

if I now move the message from 'Today' into Trash, again using drag&drop,
'Yesterday' only shows two of the three messages.

Comment 3

[gertschi]

I can confirm this bug too.

I'm getting it in version 1.5 (20051107) and it's really annoying.

Comment 4

[Stejarel Veres]

This bug is still there in Thunderbird version 1.5 (20051201). It also happens when you are viewing a folder and the last message (single in a group) is moved automatically (i.e. it is marked as Junk and subsequently moved into the Trash or due to an message filter).

Comment 5

[David :Bienvenu]

is this specific to drag drop as opposed to using the delete key? I see some asserts on drag drop that might be related, but I couldn't get anything bad to happen, other than the asserts. This is with trunk builds, but I believe 1.5 final had some related fixes.

If you have steps to reproduce with 1.5 final or a trunk build, that would be very helpful. Including if you're reverse sorted or not, and whether the groups are expanded or not.

Comment 6

[David :Bienvenu]

Attachment: possible fix

with drag drop in this scenario, I do see that we send an extra notification to the outliner, so we tell it three rows are deleted instead of two. The removed code isn't needed, because nsMsgGroupView::OnHdrDeleted calls nsMsgDBView::RemoveByIndex on the dummy thread header if the group becomes empty.

The delete key case is different because we go through the m_deletingRows codepath, which doesn't have this bug...and the delete key case works.

Comment 7

[Oliver Crow]

I haven't tried David's fix yet, but I can confirm this bug in Thunderbird 1.5 20051201. The problem occurs when you drag-and-drop the last message from the last group of a folder that is grouped by sort. It doesn't occur when you use the delete key to remove the final message of a group. The symptoms are that the final message of the previous group disappears from view until you reload the folder. You can tell that it has happened because the dotted line that joins together messages in a group is a sideways "T" shape for the last item in the group instead of an "L" shape.

Steps to reproduce:
1) Create a new folder
2) Move into the folder three messages dated today and three dated yesterday.
3) Open the folder and do View > Sort by > Grouped by Sort
4) Click the plus sign to open the "Yesterday" and "Today" groups
5) Drag each of the today messages out of the folder into another folder.
6) When you drag the final today message out, there will be two messages showing in the yesterday folder, instead of three

Comment 8

[Daniel Steinbrook]

Thanks for clarifying my horribly-worded bug report.

(In reply to comment #7)
> I haven't tried David's fix yet, but I can confirm this bug in Thunderbird 1.5
> 20051201. The problem occurs when you drag-and-drop the last message from the
> last group of a folder that is grouped by sort. It doesn't occur when you use
> the delete key to remove the final message of a group. The symptoms are that
> the final message of the previous group disappears from view until you reload
> the folder. You can tell that it has happened because the dotted line that
> joins together messages in a group is a sideways "T" shape for the last item in
> the group instead of an "L" shape.
> 
> Steps to reproduce:
> 1) Create a new folder
> 2) Move into the folder three messages dated today and three dated yesterday.
> 3) Open the folder and do View > Sort by > Grouped by Sort
> 4) Click the plus sign to open the "Yesterday" and "Today" groups
> 5) Drag each of the today messages out of the folder into another folder.
> 6) When you drag the final today message out, there will be two messages
> showing in the yesterday folder, instead of three
> 

Comment 9

[Oliver Crow]

One more caveat.  The group from which you are removing a message need not be the final group. If you remove the last message from the "old mail" group, leaving only messages in the "today" group, the bug will show up and the last message in the "today" group will not be displayed.

Comment 10

[David :Bienvenu]

please try a nightly build from tomorrow, either trunk or 1.8.1 branch, thx!

Comment 11

[David :Bienvenu]

*** Bug 304460 has been marked as a duplicate of this bug. ***

Comment 12

[Oliver Crow]

I've confirmed that the fix works in the 20060320 nightly build (v3 alpha1). Dragging messages out of a grouped folder no longer causes messages to disappear (except for the intended one, of course!)

Thanks!!

Comment 13

[David :Bienvenu]

thx, marking verified.

Comment 14

[Mike Cowperthwaite]

*** Bug 315372 has been marked as a duplicate of this bug. ***