291428 - Seamonkey Versioning is rejected by AddItem.php

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Michael (GoodWill)]

I looked over all the bugs regarding VersionCheck.php and it seems (to me at
least) that this particualr concern is not really foudn any of them.

I tried to submit an extension and got back an error:
Error! The MaxAppVer for Mozilla of 1.8a4 in install.rdf is invalid.
Errors were encountered during install.rdf checking...

I looked at VersionCheck.php and it complies with the proper versioning. It
however does not comply with versioning for Seamonkey which has letters in it. 
(ex. 1.8a1, 1.8a6 , 1.8b1) 
Now I know Seamonkey is now the unofficial child of mozilla but should not this
somehow be addressed in VersionCheck.php. 
The only workaroudn so far is to make it version 1.8
I am positive there enough changes between lets say 1.8a1, and 1.8b1 to break
some extensions. Marking them all as 1.8 is probably not gonna work.

Comment 1

[Michael Morgan [:morgamic]]

I will double check this by passing VersionCheck.php ?debug=true with various
Seamonkey versions.  I apologize for the inconvenience -- in the slimming down
of this script I removed some of the string manipulation and unnecessary looping
and this must be the source of the problem.  I will see what I can do to modify
the SQL query so that it accomodates the extra characters in Seamonkey versions.
 Thanks for submitting this bug.

Comment 2

[Michael (GoodWill)]

Attachment: this contains the install.rdf that is rejeted.

this contains the install.rdf that is rejeted.

Comment 3

[Michael (GoodWill)]

Attachment: the install.rdf with 1.8a4 for mozilla

the install.rdf with 1.8a4 for mozilla

Comment 4

[alanjstr]

The issue is with additem, not versioncheck.

Comment 5

[alanjstr]

Did you use the GUID that belongs to mozilla.org, or the one that belongs to the
new project?  If the latter, then this is a duplicate bug.

Comment 6

[Michael (GoodWill)]

That guid belongs to mozilla. That is the guid for mozilla suite/seamonkey.

    <em:targetApplication>
     <Description>
       <em:id>{86c18b42-e466-45a9-ae7a-9b95ba6f5640}</em:id>
       <em:minVersion>1.7</em:minVersion>
       <em:maxVersion>1.8a4</em:maxVersion>
     </Description>
   </em:targetApplication>    

Comment 7

[alanjstr]

int_version is null.  Bug 284025 will fix the root cause.

Comment 8

[:gerard-majax]

The additem.php doesn't want to play with SeaMonkey 1.5

Error! The MaxAppVer for SeaMonkey of 1.5 in install.rdf is invalid.

<!-- target: SeaMonkey, version 1.0 to 1.5 -->
<em:targetApplication>
	<Description>
		<em:id>{92650c4d-4b8e-4d2a-b7eb-24ecf4f6b63a}</em:id>
		<em:minVersion>1.0</em:minVersion>
		<em:maxVersion>1.5</em:maxVersion>
	</Description>
</em:targetApplication>

Comment 9

[alanjstr]

What is Seamonkey 1.5, their trunk?

Comment 10

[Cameron]

AMO bugspam. Correcting QA contacts on OLD bugs ([e-mail])

-> Correct QA contact ([e-mail])

Filtermeplzkthx

Comment 11

[Majken Connor [:Kensie]]

in light of Bug 342816 is this fixed?

Comment 12

[Justin Scott [:fligtar]]

Since there have been no replies to Majken's question, I am assuming this bug is resolved, as we do now support versions with letters in them.

If this is not resolved, please let us know.

Comment 13

[Cameron]

SeaMonkey versioning is accepted, I can verify this as I recently uploaded an add-on compatible with SeaMonkey 1.1a - 1.1

Mozilla suite versioning is definitely accepted, as you can see by the many and varied add-ons that clearly state that they are compatible with it - https://addons.mozilla.org/mozilla/10/ https://addons.mozilla.org/mozilla/220/ https://addons.mozilla.org/mozilla/1439/ etc.

1.8a4 isn't currently an accepted version number... maybe we should make it one as it did exist in the past.. but then maybe not, seeing as it's discontinued and the suite doesn't even support install.rdf anyway.