Closed Bug 291473 Opened 20 years ago Closed 20 years ago

Attaching a patch causes a software error in 2.18

Categories

(Bugzilla :: Attachments & Requests, defect)

2.18
defect
Not set
blocker

Tracking

()

RESOLVED FIXED
Bugzilla 2.18

People

(Reporter: jacob, Assigned: LpSolit)

Details

(Keywords: regression, Whiteboard: [does not affect trunk])

Attachments

(1 file)

This problem does not seem to appear on the tip, but when creating a patch and
selecting the "Patch" checkbox in 2.18, the following Software Error occurs:

Undef to trick_taint at Bugzilla/Util.pm line 51
	Bugzilla::Util::trick_taint('undef') called at
/var/www/html/bugzilla-2.18-branch/attachment.cgi line 955
	main::insert('Index:
Bugzilla.pm\x{a}==========================================...') called at
/var/www/html/bugzilla-2.18-branch/attachment.cgi line 123

This error does not occur when a content type is specified.
Flags: blocking2.18.1?
Target Milestone: --- → Bugzilla 2.18
Regression of bug 288483.
Keywords: regression
Attached patch patch, v1Splinter Review
Assignee: attach-and-request → LpSolit
Status: NEW → ASSIGNED
Attachment #181704 - Flags: review?(justdave)
Severity: critical → blocker
Flags: blocking2.18.1? → blocking2.18.1+
Comment on attachment 181704 [details] [diff] [review]
patch, v1

that's obviously correct.
Attachment #181704 - Flags: review?(justdave) → review+
Flags: approval2.18+
Whiteboard: [does not affect trunk]
Checking in attachment.cgi;
/cvsroot/mozilla/webtools/bugzilla/attachment.cgi,v  <--  attachment.cgi
new revision: 1.58.2.5; previous revision: 1.58.2.4
done
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: