291546 - Installation of non-browser extensions

Status: RESOLVED DUPLICATE of bug 333518

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Arthur Wiebe]

Currently installation of extensions that are not for browsers is not simplified
enough. Just ask mconnor :)

I will attempt to make Thunderbird extensions downloaded instead of Firefox
trying to install them. Will attach a patch tomorrow if things work. You all
know what happens when I submit a patch in the evening. hint* review-denied

Comment 1

[Arthur Wiebe]

Attachment: Version 1

I would like some opinions on whether or not this is the best way to do it.
This patch is not complete but I believe it should accomplish it's mission.

Basically  it shows Download Now links instead of Install links for Thunderbird
and install.php sends the actual file as a binary instead of redirecting to it.

Comment 2

[alanjstr]

Comment on attachment 181639 [details] [diff] [review]
Version 1

>             if ($appname=="Thunderbird") { 
>               $downloadURL=mozupd_buildDownloadURL($uri,$name,$version);

Is there a reason we don't build this for non-TB?  Also, can you use the "Not
Browser" logic like the other patch?  I'd like to keep this generic.

>+        ?></a></b>

If its TB, you didn't open a bold tag, so you shouldn't be closing it.	Move
the bold statements outside of the if statement and move the /a inside, please.

>         //Special Extension Installation Instructions for Thunderbird users
>             if ($application=="thunderbird") {

You used $appname above.  Again, this would be a good place for the "Not
Browser"

Comment 3

[Arthur Wiebe]

Attachment: Version 2

I think this one is ready for review. As long as this is the correct way to fix
this problem. I think it is.

As far as I can see this patch is ready for deployment.

Comment 4

[alanjstr]

Comment on attachment 181649 [details] [diff] [review]
Version 2

Please revise this based on bug 291616 comment 20 for escaping.

Comment 5

[Arthur Wiebe]

okedokey

Comment 6

[Cameron]

This code needs to be updated for AMO 2. Please feel free to work on 333518

*** This bug has been marked as a duplicate of 333518 ***