291564 - Show XULRunner version and help info in Windows release builds

Status: RESOLVED FIXED

(Toolkit Graveyard :: XULRunner, enhancement)

Description

[Darin Fisher]

Show XULRunner version and help info in Windows release builds

Since we don't have a console in release builds under Windows, I think it'd be
nice if we still showed the user (in this case the developer /me hopes) the
version and help info as well as some error messages pertaining to
application.ini parsing.

Comment 1

[Darin Fisher]

Attachment: v1 patch

This patch makes it so that we use MessageBox on Windows when MOZ_WINCONSOLE is
false.	I thought about launching a DOS console (via AllocConsole), but I think
I prefer MessageBox.

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

how about reusing ShowOSAlert? that has code for non-windows platforms too, and
seems to be used in toolkit/xre already.

Comment 3

[Darin Fisher]

(In reply to comment #2)
> how about reusing ShowOSAlert? that has code for non-windows platforms too, and
> seems to be used in toolkit/xre already.

No, this message is intended for developers.  On unix systems, dumping to the
console seems most appropriate and far more convenient than showing a popup
dialog.  I think developers on unix systems will appreciate being able to do:

  bash$ ver=($(xulrunner -v 2>&1))
  bash$ build_id=${ver[3]}

and fun things like that :)

Comment 4

[Benjamin Smedberg]

Comment on attachment 181603 [details] [diff] [review]
v1 patch

Don't checkin the __asm break-on-load bits. And remove the XXXlocalizable
comment, it's unnecessary and would be very complicated to implement.

Comment 5

[Darin Fisher]

Thanks, I did not mean to include the __asm bits.

Comment 6

[Darin Fisher]

Comment on attachment 181603 [details] [diff] [review]
v1 patch

This patch is XULRunner only.

Comment 7

[chris hofmann]

Comment on attachment 181603 [details] [diff] [review]
v1 patch

a=chofmann

Comment 8

[Darin Fisher]

fixed-on-trunk