291613 - findBar.js uses numbers when it should be using constants

Status: RESOLVED FIXED

(Toolkit :: Find Toolbar, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

findBar.js uses numbers for charCode and keyCode where it ought to be using
constants for better readability.  (I did this in attachment 181606 [details] [diff] [review], but that's
the wrong approach for bug 259454.)

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 2

[Mike Connor [:mconnor]]

Comment on attachment 181645 [details] [diff] [review]
patch

I think you're right about that code chunk being unreachable, but the comment's
fine for now.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 181645 [details] [diff] [review]
patch

I was planning to wait on this, but given the delays, I may as well get it in. 
It's pretty low risk, and if it breaks something, it should be pretty obvious.

Comment 4

[Asa Dotzler [:asa]]

Comment on attachment 181645 [details] [diff] [review]
patch

a=asa

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk, 2005-04-28 13:51 -0700.