291673 - The default theme is not displayed in the Theme Manager - fallout from bug 286034

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Robert Strong (they/them - no direct email)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050423 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050423 Firefox/1.0+

The checking for bug 286034 changed the default theme's minVersion and
maxVersion to 1.1 but left app.extensions.version at 1.0 which prevents the
default theme from registering or showing in the Theme Manager. The following is
reported to the JS Console:
Item Installed via directory addition to Install Location: app-global Item ID:
{972ce4c6-7e08-4474-a285-3208198ce6fd}, attempting to register...

Item Installed/Upgraded at Install Location: app-global Item ID:
{972ce4c6-7e08-4474-a285-3208198ce6fd}, attempting to register...

... failure, item is not compatible

Reproducible: Always

Steps to Reproduce:

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: simple patch

bumps the theme's minVersion and maxVersion down to 1.0

Comment 2

[Benjamin Smedberg]

Comment on attachment 181679 [details] [diff] [review]
simple patch

I would mark r+, but I'm not sure whether Ben forgot to checkin firefox.js

Comment 3

[Robert Strong (they/them - no direct email)]

(In reply to comment #2)
> (From update of attachment 181679 [details] [diff] [review] [edit])
> I would mark r+, but I'm not sure whether Ben forgot to checkin firefox.js

He didn't forget to check it in. He went with 1.0 for app.extensions.version
after your review comment of "Do we really want to bump extensions.version to
1.1 now? What about 1.0+? I would save 1.1 for 1.1b or even the first release
candidate."

Comment 4

[Benjamin Smedberg]

Comment on attachment 181679 [details] [diff] [review]
simple patch

ok then, let's get this landed.

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

patch checked in as part of 291831

Comment 6

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050425
Firefox/1.0+ 13:29PDT build

veryfied on win32