Closed
Bug 291716
Opened 20 years ago
Closed 20 years ago
Install missing plugins... button only works once
Categories
(Toolkit Graveyard :: Plugin Finder Service, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.8final
People
(Reporter: bugzilla, Assigned: doronr)
References
()
Details
Attachments
(1 file)
|
1.74 KB,
patch
|
mconnor
:
review+
mkaply
:
approval-aviary1.1a1+
|
Details | Diff | Splinter Review |
Build: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050422 Firefox/1.0+ Visit http://vnuuk.typepad.com/silicon_valley_sleuth/, you will get the toolbar saying that addtional plugins are required for that page. Now press the "install missing plugins..." button to the right. The dialog will say that no plugins were found, click finish to close it. Now click on the button again. Nothing will happend.
|
Assignee | |
Comment 2•20 years ago
|
||
The issue is, I am clearing the missing plugins array every time, even if none was installed. And the wizard won't show unless the array is non-empty. Solution: only clear if we installed something, which will cause a page reload and thus a fresh new missing plugins array if anything is still missing.
Attachment #181799 -
Flags: review?(mconnor)
|
||
Updated•20 years ago
|
Attachment #181799 -
Flags: review?(mconnor) → review+
|
||
Comment 3•20 years ago
|
||
Comment on attachment 181799 [details] [diff] [review] patch a=mkaply
Attachment #181799 -
Flags: approval-aviary1.1a+
|
|
Assignee | |
Comment 4•20 years ago
|
||
checked in.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
||
Updated•16 years ago
|
Product: Firefox → Toolkit
|
|
||
Updated•10 years ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•