291725 - Change NS_POPUP_EVENT to NS_POPUPBLOCKED_EVENT

Status: RESOLVED FIXED

(Core :: DOM: Events, defect, P2)

Description

[Ilya Konstantinov]

From a short LXR search, it looks like all popup blocked events are now
generated with mEvent->eventStructType == NS_POPUPBLOCKED_EVENT, so both
content/events/src/nsDOMUIEvent.cpp and
content/events/src/nsEventListenerManager.cpp should be changed not to refer to
NS_POPUP_EVENT anymore.

(I don't have a building Mozilla tree right now, so this bug is just for
reference and a reminder till I find time to post a tested patch.)

Comment 1

[Boris Zbarsky [:bzbarsky]]

*** Bug 292543 has been marked as a duplicate of this bug. ***

Comment 2

[Boris Zbarsky [:bzbarsky]]

We shouldn't ship 1.8 with this issue....

Note also that it looks like NS_POPUP_EVENT can be removed altogether.

Comment 3

[Benjamin Smedberg]

Boris, does this really block the release?

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I think so; it's a bunch of core regressions from a change we took in the 1.8
cycle that broke many things to do with popupblocked events and probably some to
do with popup events as well.

Comment 5

[Chris Beard]

dbaron, would you be able to take a pass at resolving this?  

/cb

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

OK, some notes, before I forget:

NS_POPUP_EVENT is for popupshowing, popupshown, popuphiding, and popuphidden. 
This should be an nsDOMUIEvent.  The group is "PopupEvents".  See bug 112286 and
bug 133426 for some history.

NS_POPUPBLOCKED_EVENT is for DOMPopupBlocked.  This should be an
nsPopupBlockedEvent.  See bug 199705.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Sorry, the popup events should be nsDOMMouseEvent, since they have coordinates.

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch #1

Currently untested.

The event code really needs to stop storing data in the form of code,
especially code spread out in many different places.

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 190781 [details] [diff] [review]
patch #1

Not really sure how to test this, but requesting reviews...

Comment 10

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 190781 [details] [diff] [review]
patch #1

I see what you mean about data in code... :(

Comment 11

[Johnny Stenback (:jst)]

Comment on attachment 190781 [details] [diff] [review]
patch #1

r=jst

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk, 2005-08-02 13:18/38 -0700.