291764 - Some animated gifs animate in Print Preview if looping is set to once

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[zug_treno]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b) Gecko/20050217
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b) Gecko/20050217

The animated ads on some pages still animate when I view the page (or image) in
Print Preview, I only see this if I set animated images to loop once.

Reproducible: Sometimes

Steps to Reproduce:
1.Set Edit>Preferences>Privacy&Security>Images>Animated images should loop Once.
2.Load (a page with) an animated gif.
3.Go to File>Print Preview (before the image loops once?).

Actual Results:  
The image is animated as many times as the it specifies.

Expected Results:  
No animation at all.

Reproducible with Mozilla 1.7.6, Mozilla 1.8b1, Mozilla 1.8b2/20050424 and
Firefox/1.0+ Gecko/20050424 (set image.animation_mode to 'once' in about:config).

See also Core bug 2586.

Comment 1

[zug_treno]

Attachment: Random animated ad

I used this image to reproduce this bug with the different Mozilla/Firefox
versions.

Comment 2

[Frank Wein [:mcsmurf]]

Already occours with builds from and before 2005-04-03, so not related to Bug 291485

Comment 3

[Boris Zbarsky [:bzbarsky]]

So what are the exact steps to reproduce with that attachment?  Do I just load
the attachment and then print preview?

Comment 4

[Boris Zbarsky [:bzbarsky]]

So yes, with the steps in comment 3 I see this bug in builds going back to Jan
2003.  So it looks like this has just never worked right....

Comment 5

[[e-mail]]

Attachment: Extravagent patch

The cheap and cheerful patch simply stops the animation if the new mode is
don't animate and starts it if the new mode is normal while if the new mode is
once then it doesn't start or stop the animation.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Over to imagelib.

Comment 7

[Chris Beard]

closing out for 1.8b3, would be good to get this in for 1.8b4

Comment 8

[[e-mail]]

Fix checked in to the trunk.