291830 - Pane selection icons jump and dance 1px horizontally on Mac

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Mark Mentovai]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050423 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050423 Firefox/1.0+

The pane selection radio icons (General, Privacy, etc.) jump to the left and
right depending on which pane is selected.  The selected icon and all icons to
the right of it are bumped 1px to the right.  When the selection is changed, the
icons jump accordingly.

Reproducible: Always

Steps to Reproduce:
Firefox:Preferences..., click the General icon.

Click Content.  Observed result: the General and Privacy icons moved one pixel
to the left.  Expected result: the icons should have stayed in place.

Click Privacy.  Observed result: the Privacy icon moves one pixel to the right.
 Expected result: the icon should not have exhibited symptoms of ADD.

Repeat ad nauseam.  Then apply the simple patch.



This bug only occurs on Mac OS X.  It is in the Pinstripe theme.

Comment 1

[Mark Mentovai]

Attachment: Ritalin for preference pane icons

No border-style was specified in preferences.css for border-left on unselected
icons, but a border-style was specified for selected ones.  Add
border-style:solid to border-left for unselected icons, matching selected icons
and border-right.

Comment 2

[Mike Connor [:mconnor]]

Comment on attachment 181786 [details] [diff] [review]
Ritalin for preference pane icons

move this to Kevin, since he owns the theme and all.

Comment 3

[Mike Connor [:mconnor]]

Josh, can you also take a look at this, since Kevin's not here for another
couple days.  At this rate, I need a Mac.

Comment 4

[Josh Aas]

Comment on attachment 181786 [details] [diff] [review]
Ritalin for preference pane icons

looks fine to me as long as someone has tested the fix. I can't try it out at
the moment

Comment 5

[Mark Mentovai]

I tested it.  It does what it's supposed to, nothing more and nothing less.

Comment 6

[Mark Mentovai]

Does this need sr, or can it be committed?

Comment 7

[Mike Connor [:mconnor]]

needs approval-aviary1.1a

Comment 8

[Mark Mentovai]

Comment on attachment 181786 [details] [diff] [review]
Ritalin for preference pane icons

Requesting

Comment 9

[Asa Dotzler [:asa]]

Comment on attachment 181786 [details] [diff] [review]
Ritalin for preference pane icons

a=asa

Comment 10

[Mark Mentovai]

This has approval-aviary1.1a+, is anything else needed?

Comment 11

[Asaf Romano (gone)]

No. I'll check it in tomorrow.

Comment 12

[Asaf Romano (gone)]

Checking in preferences.css;
/cvsroot/mozilla/browser/themes/pinstripe/browser/preferences/preferences.css,v
 <--  preferences.css
new revision: 1.5; previous revision: 1.4
done

Comment 13

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs,
filter on "beltznerLovesGoats" to get rid of this mass change