291831 - Various EM Issues (Fallout from 286034)

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

bug 286034 introduced several regressions, such as 291582, 291673, 291675 and
291709, as well as a few other perhaps as yet undocumented regressions. 

Here is a rollup patch that addresses a variety of these. Much of this patch
includes work done by Benjamin Smedberg and others in the bugs listed above. I
have applied these in my tree and diffed in addition to my own fixes.

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: rollup patch

Comment 2

[Caleb]

This patch doesn't seem to fix bug 286034 comment 71.

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: more...

rollup of fixes for 291726 (patch by anbo motohiko) - firefox reports updates
that have already been installed
291791 - removing install.rdf for user-managed item deletes entire directory

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 181795 [details] [diff] [review]
more... 

also includes patch by Robert Strong for bug 291572 (em namespaces changed)

Comment 5

[Robert Strong (they/them - no direct email)]

Ben - there is one change you missed from the patch in bug 291572.
http://lxr.mozilla.org/seamonkey/source/toolkit/mozapps/extensions/content/extensions.js#910

Comment 6

[Nickolay_Ponomarev]

The patch appears to also fix bug 291790?

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 181787 [details] [diff] [review]
rollup patch

a=asa

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 181795 [details] [diff] [review]
more... 

a=asa

Comment 9

[Robert Strong (they/them - no direct email)]

It appears that the second patch hasn't been checked in as well.

Comment 10

[Brendan Eich [:brendan]]

Please see bug 291582 comment 11, something for later, or for your general JS
regexp knowledge.

/be

Comment 11

[Ben Goodger (use ben at mozilla dot org for email)]

second patch landed