291841 - XForms controls can't lay out like a table

Status: RESOLVED DUPLICATE of bug 83830

(Core Graveyard :: XForms, defect)

Description

[aaronr]

Using CSS, it should be possible to layout an XForm like a table.  However, when
tried on Mozilla, NONE of the controls appear.  Probably a limitation of these
syles on XTF elements?  Seems to be wreking havoc.

Comment 1

[aaronr]

Attachment: testcase

This testcase doesn't layout right in other xforms processors, either.	Doron
thinks that this is because IE doesn't support display:table  But at least the
other processors show the controls.

Comment 2

[Anne (:annevk)]

IE doesn't. We don't support on 'display' on HTML input types either. Actually,
they make inputs do weird things, see bug 281357.

There is basically no CSS specification that deals with form controls (which are
some special kind of replaced elements last time I debated about it).

Comment 3

[Martijn Wargers (dead)]

Probably this has got something to do with bug 266772, not?

Comment 4

[Doron Rosenberg (IBM)]

Now that we moved to xbl widgets, is this fixed?

Comment 5

[Allan Beaufour]

(In reply to comment #4)
> Now that we moved to xbl widgets, is this fixed?

Does not look good in current nightly, so no I guess.

Comment 6

[Doron Rosenberg (IBM)]

Attachment: patch

tablelayout needs xbl created content it seems, and group doesn't have any.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 199822 [details] [diff] [review]
patch


>+
>+    <implementation implements="nsIXFormsUIWidget">
>+    </implementation>

Do you need <implementation> for anything?

Comment 8

[Doron Rosenberg (IBM)]

actually, the implementation isn't needed it seems.

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 199822 [details] [diff] [review]
patch

Remove <implementation> and
add class attribute to the html:div. In xforms.css 
set display:inherit; to that class.
With those r=me.

Comment 10

[Doron Rosenberg (IBM)]

There is a problem with setting display:inherit; on the div - the testcase
breaks.  Removing the inherit fixes the issue, but removes the option of doing
inline groups (well, you won't be able to style groups inline, but would have to
do xf|group > html|div {display: inline}.

Anyone else have an opinion? :)

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

If you have display:inherit; you could still make group to work like a table:
xf|group > html|div {display: table}.   ;)

Comment 12

[Doron Rosenberg (IBM)]

do we ened inline groups? :)

Comment 13

[Doron Rosenberg (IBM)]

So currently, we have two options:

A patch that allows group as a table, but that can't be inline (without css to style the anonymous content).

or

A patch that allows inline/block groups, but can't be a group (without ss to style  the anonymous content)

Note that you probably can simple not style the group a table but its children as table-rows and make this work with the inline/block option.

Comment 14

[Doron Rosenberg (IBM)]

So we have two choices for 1.8 (1.9 will have inline-block that will probably help us).  Any reactions? :)

Comment 15

[Allan Beaufour]

Attachment: Revised testcase

Comment 16

[alexander :surkov (:asurkov)]

The main problem is that XBL bindigns doesn't applied to elements that have 'table-row' or 'table-cell' display property. After bug 83830 will be fixed we need ensure testcases work. And if they work then we will mark this bug as dublicate of bug 83830.

Comment 17

[Alexey Gaidukov]

(In reply to comment #1)
> Created an attachment (id=181790) [details]
> testcase
> 
> This testcase doesn't layout right in other xforms processors, either.	

Aaron, can you explain what layout is right? In current version of xforms I can see controls.

Comment 18

[aaronr]

Attachment: what I see on FF 3.0.15

When I tried the latest nightly with 3.6.3 it crashed, so I tried this testcase on 3.0.15.  If what you are seeing is the same as what is in this bmp, then let me know and we can close this as worksforme.  You'll have to modify the testcase slightly to add other inputs with variable length labels to make sure the table layout is correct.  Thanks.

Comment 19

[Alexey Gaidukov]

Attachment: FF 3.6.3

FF 3.6.3 with XForms from https://bugzilla.mozilla.org/attachment.cgi?id=437883

Comment 20

[aaronr]

looks good, closing as duplicate of 83830 per Alex's comment.