291846 - Save Link/Image As are dysfunctional: File not saved after selecting

Status: RESOLVED FIXED

(Firefox :: General, defect, P1)

Description

[Mike Pesce (:By-Tor)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050425 Firefox/1.0+  (bangbang023)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050425 Firefox/1.0+  (bangbang023)

When trying to save an image using the Save Image As context menu, the dialog
for where to save the file appears, but no file is saved.  The same happens with
Save Link As with certain file types such as XPI files.

Reproducible: Always

Steps to Reproduce:
1. Select Save Image As...
2. Confirm the file name to download
3.

Actual Results:  
No file is actually downloaded.

Expected Results:  
The file should have downloaded as usual.

Comment 1

[Joël Kuiper]

Yep it is also happening here (Gecko/20050425 Firefox/1.0+).
It happens for all types of images and xpi files.
I am confirming this, couldn't find a duplicate

Comment 2

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050425
Firefox/1.0+

Confirming

this must be a fairly recent regression
I'm sure it worked a days ago

Comment 3

[Peter van der Woude [:Peter6]]

possible falout from bug 290648
CC cbiesinger

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

hm, this does indeed fail for me in a current nightly (linux), but I want to
note that my ffox build with the patch for that bug does not show this problem...

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

(In reply to comment #4)
> hm, this does indeed fail for me in a current nightly (linux), but I want to
> note that my ffox build with the patch for that bug does not show this problem...

That's because that build was slightly out of date - a later change to that
patch broke it :(

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

let's pass a string for the string argument and a null for the object argument

very low risk patch

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 181832 [details] [diff] [review]
patch

a=asa

Comment 8

[Thomas K. (:tom)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050425
Firefox/1.0+

I can't download these lovely sin city wallpapers :(
http://sincitythemovie.com/misc/wallpapers/wp_jpgs/

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in toolkit/content/contentAreaUtils.js;
/cvsroot/mozilla/toolkit/content/contentAreaUtils.js,v  <-- 
contentAreaUtils.jsnew revision: 1.69; previous revision: 1.68
done

btw, as for comment 8: comments like that are in general not useful once there
is a patch, and often not even before that...