Closed Bug 291859 Opened 20 years ago Closed 17 years ago

editparams.cgi should sanity check urlbase parameter

Categories

(Bugzilla :: Administration, task)

Product:
Bugzilla
Component:
Administration
Type:
task
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: chris.raplee, Unassigned)

References

(
URL
)

Details

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1; .NET CLR 1.1.4322)
Build Identifier: 

The urlbase parameter needs to be a valid url and contain a trailing slash. 
Throwing a warning if the admin doesn't enter a valid url or is missing their 
trailing slash can help protect the user from themselves. 

Reproducible: Always

Steps to Reproduce:
It already checks the trailing slash. Now should it makes sure that the URL starts with #^https?://# ?
Max, what's your opinion?
It already checks both:

if ($url && $url !~ m:^http.*/$:) {
Status: UNCONFIRMED → RESOLVED
Closed: 17 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.