Closed Bug 291870 Opened 19 years ago Closed 19 years ago

Unable to lock secure connection SMTP setting

Categories

(Thunderbird :: Account Manager, defect)

Product:
Thunderbird
Component:
Account Manager
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird1.1

People

(Reporter: mscott, Assigned: neil)

Details

Attachments

(2 files)

the fix
1.69 KB, patch
Bienvenu
: superreview+
Details | Diff | Splinter Review
Better fix
2.73 KB, patch
mscott
: review+
Bienvenu
: superreview+
asa
: approval-aviary1.1a1+
Details | Diff | Splinter Review 
Enterprise folks cannot lock the account manager smtp server setting for the
type of secure connection to be used.

The SSL radio button in that radio group is never disabled.
Attached patch the fix — — Splinter Review 
disable the SSL radio button in addition to the rest of the radio elements
which were already getting disabled if the smtp secure connection pref is
locked.
Attachment #181811 - Flags: superreview?(bienvenu)
Status: NEW → ASSIGNED
Target Milestone: --- → Thunderbird1.1
Attachment #181811 - Flags: superreview?(bienvenu) → superreview+
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Actually there was a better fix for this in one of the original patches to bug
202468 but unfortunately that was one of the bits that didn't land :-(
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch Better fix — — Splinter Review 
This uses the radiogroup's disabled property, which does the right thing.
Assignee: mscott → neil.parkwaycc.co.uk
Status: REOPENED → ASSIGNED
Attachment #181921 - Flags: superreview?(bienvenu)
Attachment #181921 - Flags: review?(mscott)
Attachment #181921 - Flags: superreview?(bienvenu) → superreview+
Comment on attachment 181921 [details] [diff] [review]
Better fix

i was trying radiogroup.setAttribute("disabled",  true); and that wasn't
working.

.disabled I see does work. Thanks Neil.
Attachment #181921 - Flags: review?(mscott) → review+
Comment on attachment 181921 [details] [diff] [review]
Better fix

Low risk cleanup after previous fix.
Attachment #181921 - Flags: approval-aviary1.1a?
Comment on attachment 181921 [details] [diff] [review]
Better fix

a=asa
Attachment #181921 - Flags: approval-aviary1.1a? → approval-aviary1.1a+
Cleanup patch checked in.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago → 19 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: