291874 - XML parsing error at startup when --enable-chrome-format=flat used (broken *.manifest files)

Status: RESOLVED FIXED

(Toolkit Graveyard :: Build Config, defect)

Description

[PikeUK]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050426
Firefox/1.0+

When using --enable-chrome-format=flat to build Firefox the final build opens a
window showing XML parsing errors. The outputted en-US.manifest and
toolkit.manifest are broken (see example below), I think this was caused by the
checkin from Bug 289461.

mozconfig:

mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/../ff-opt
mk_add_options MOZ_CO_PROJECT=browser
ac_add_options --enable-application=browser
ac_add_options --enable-official-branding
ac_add_options --enable-svg
ac_add_options --disable-tests
ac_add_options --enable-optimize
ac_add_options --enable-chrome-format=flat

Example broken toolkit.manifest:

content help toolkit//cygdrive/c/Mozilla/mozilla/config/make-jars.plcontent/help/

Changing the following line in make-jars.pl from using $0 to $1 seems to fix the
problem:

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/config/make-jars.pl&rev=3.78&mark=532#531

Comment 1

[Benjamin Smedberg]

Wanna make a patch?

Comment 2

[PikeUK]

Attachment: Trivial fix for flat chrome

Comment 3

[Darin Fisher]

Comment on attachment 182008 [details] [diff] [review]
Trivial fix for flat chrome

r=darin

Comment 4

[Alex Vincent [:WeirdAl]]

Did I just file bug 295023 as a dupe of this bug? :(

(That would make sense, for my first XULRunner bug to be a dupe...)

Comment 5

[Alex Vincent [:WeirdAl]]

Uh, one small problem:  the patch appears necessary, but not sufficient, to fix
flat chrome builds.

I get the following alert:
"The file
file:///M:/builds/xulflat/dist/xpi-stage/simple/chrome/simple.jar!/content/simple/simple.xul
cannot be found.  Please check the location and try again."

Comment 6

[PikeUK]

Comment on attachment 182008 [details] [diff] [review]
Trivial fix for flat chrome

This was fixed by the patch in Bug 295494, flat chrome now WFM again.

Comment 7

[PikeUK]

Forgot to close this. Fixed by checkin from Bug 295494.