291876 - Malformed URIs are badly handled in "xul" error pages

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P1)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

Malformed URIs (ie, those where NS_NewURI throws) do not get entered in session
history. That means that pressing back goes back one page too far.

As an interim solution, I suggest falling back to an alert for those errors.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: fall back to alert

Comment 2

[Darin Fisher]

Comment on attachment 181831 [details] [diff] [review]
fall back to alert

I vote for this plan, sr=darin

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 181831 [details] [diff] [review]
fall back to alert

low risk patch to a feature that's disabled by default; but it's probably an
important change if we want to enable error pages.

Comment 4

[Asa Dotzler [:asa]]

Comment on attachment 181831 [details] [diff] [review]
fall back to alert

a=asa

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in docshell/base/nsDocShell.cpp;
/cvsroot/mozilla/docshell/base/nsDocShell.cpp,v  <--  nsDocShell.cpp
new revision: 1.675; previous revision: 1.674
done