Closed
Bug 291876
Opened 20 years ago
Closed 20 years ago
Malformed URIs are badly handled in "xul" error pages
Categories
(Core :: DOM: Navigation, defect, P1)
Core
DOM: Navigation
Tracking
()
RESOLVED
FIXED
mozilla1.8beta2
People
(Reporter: Biesinger, Assigned: Biesinger)
References
Details
Attachments
(1 file)
|
1.19 KB,
patch
|
bzbarsky
:
review+
darin.moz
:
superreview+
asa
:
approval1.8b2+
|
Details | Diff | Splinter Review |
Malformed URIs (ie, those where NS_NewURI throws) do not get entered in session
history. That means that pressing back goes back one page too far.
As an interim solution, I suggest falling back to an alert for those errors.
|
Assignee | |
Comment 1•20 years ago
|
||
Attachment #181831 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Updated•20 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → mozilla1.8beta2
|
||
Comment 2•20 years ago
|
||
Comment on attachment 181831 [details] [diff] [review]
fall back to alert
I vote for this plan, sr=darin
Attachment #181831 -
Flags: superreview+
|
||
Updated•20 years ago
|
Attachment #181831 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 3•20 years ago
|
||
Comment on attachment 181831 [details] [diff] [review]
fall back to alert
low risk patch to a feature that's disabled by default; but it's probably an
important change if we want to enable error pages.
Attachment #181831 -
Flags: approval1.8b2?
|
||
Comment 4•20 years ago
|
||
Comment on attachment 181831 [details] [diff] [review]
fall back to alert
a=asa
Attachment #181831 -
Flags: approval1.8b2? → approval1.8b2+
|
|
Assignee | |
Comment 5•20 years ago
|
||
Checking in docshell/base/nsDocShell.cpp;
/cvsroot/mozilla/docshell/base/nsDocShell.cpp,v <-- nsDocShell.cpp
new revision: 1.675; previous revision: 1.674
done
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•