291898 - linking of libgfx_gtk.so fails

Status: RESOLVED INVALID

(SeaMonkey :: Build Config, defect)

Description

[Wolfgang Rosenauer [:wolfiR]]

The following does happen only if --with-system-nspr is used and therefore
-L/usr/lib is included instead of -L../../../dist/lib (or any other path to the
NSPR libs) in the make command. We just have to add -L../../../dist/lib to find
libgfxshared_s

c++ -I/usr/X11R6/include -fno-rtti -fno-exceptions -Wall -Wconversion
-Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy
-Wno-non-virtual-dtor -Wno-long-long -
pedantic -O2 -march=i586 -mtune=i686 -fmessage-length=0 -Wall -g
-fno-strict-aliasing -fshort-wchar -pthread -pipe  -DNDEBUG -DTRIMMED
-ffunction-sections -O2 -march=i586 -mtune=i686 -fmess
age-length=0 -Wall -g -fno-strict-aliasing  -DXTHREADS -D_REENTRANT
-DXUSE_MTSAFE_API -I/opt/gnome/include/gtk-2.0 -I/opt/gnome/lib/gtk-2.0/include
-I/usr/X11R6/include -I/opt/gnome/include
/atk-1.0 -I/opt/gnome/include/pango-1.0 -I/usr/include/freetype2
-I/usr/include/freetype2/config -I/opt/gnome/include/glib-2.0
-I/opt/gnome/lib/glib-2.0/include   -fPIC -shared -Wl,-h -Wl,l
ibgfx_gtk.so -o libgfx_gtk.so  nsPrintdGTK.o gtk2drawing.o nsDeviceContextGTK.o
nsDeviceContextSpecFactoryG.o nsDeviceContextSpecG.o nsDrawingSurfaceGTK.o
nsGfxFactoryGTK.o nsGraphicsStateG
TK.o nsImageGTK.o nsGCCache.o nsRenderingContextGTK.o nsScreenGtk.o
nsScreenManagerGtk.o nsPrintOptionsGTK.o nsFontMetricsUtils.o
nsAntiAliasedGlyph.o nsX11AlphaBlend.o nsXFontAAScaledBitma
p.o nsXFontNormal.o nsFontMetricsGTK.o nsGdkUtils.o nsFontMetricsXft.o
nsRegionGTK2.o nsNativeThemeGTK.o       -Wl,--version-script
-Wl,../../../build/unix/gnu-ld-scripts/components-version
-script -Wl,-Bsymbolic -L../../../dist/bin -lxpcom  -L../../../dist/bin
-L/usr/lib -lplds4 -lplc4 -lnspr4 -lpthread -ldl -lgkgfx -lgfxshared_s
-lXinerama -L../../../dist/bin -lmozjs ../../.
./dist/lib/libunicharutil_s.a   -L/usr/X11R6/lib -lXft -lX11 -lfreetype
-lXrender -lfontconfig   -L/opt/gnome/lib -lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0
-lgdk_pixbuf-2.0 -lm -lpangoxft-1.0 -
lpangox-1.0 -lpango-1.0 -lgobject-2.0 -lgmodule-2.0 -ldl -lglib-2.0  
-lxprintutil -L/usr/X11R6/lib -lXp -lXext -lX11 -ldl -lm    
/usr/lib/gcc/i586-suse-linux/4.0.1/../../../../i586-suse-linux/bin/ld: cannot
find -lgfxshared_s
collect2: ld returned 1 exit status

Comment 1

[Wolfgang Rosenauer [:wolfiR]]

Attachment: possible patch

don't know if this is the right way but it seems to fix it
(please note that this is 1.7 branch)

Comment 2

[Wolfgang Rosenauer [:wolfiR]]

Attachment: fixed typo

Comment 3

[Wolfgang Rosenauer [:wolfiR]]

Comment on attachment 183795 [details] [diff] [review]
fixed typo

sorry for the spam. I'm not sure if the patch really works and will do some
more testing.

Comment 4

[Wolfgang Rosenauer [:wolfiR]]

Comment on attachment 183795 [details] [diff] [review]
fixed typo

OK, my previous build was corrupt because of the first typo. This patch works
for me.

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

ah. trunk already has this change:
1.110 <[e-mail]> 2004-04-24 17:44
Fix link order.


http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/gfx/src/gtk&command=DIFF_FRAMESET&file=Makefile.in&rev2=1.110&rev1=1.109

Note also:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/gfx/src/gtk&command=DIFF_FRAMESET&file=Makefile.in&rev2=1.116&rev1=1.115

Comment 6

[Wolfgang Rosenauer [:wolfiR]]

I wanted a patch as simple as possible. BTW, if this needs super-review. Who
would do that?

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

no sr needed for build config patches

I was just mentioning those checkins to point out it's fixed on trunk.

Comment 8

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 183795 [details] [diff] [review]
fixed typo

Let's get the full patch for the branch, if we want it.  This only patches GTK2
and leaves GTK unpatched.  See e.g. biesi's comment 5 and
http://cvs.fedora.redhat.com/viewcvs/*checkout*/devel/firefox/firefox-1.0-gfxsh
ared_s.patch

Also, we need 1.7.x to equal aviary1.0.x

Comment 9

[Wolfgang Rosenauer [:wolfiR]]

Chris, as you already have the *complete* patch in your Fedora RPM, would you
mind to attach it to get it in the branches?

Comment 10

[cls]

*** Bug 301659 has been marked as a duplicate of this bug. ***

Comment 11

[Robert Kaiser]

no indication that this happens on any 1.8-based (or newer) build, so not blocking a SeaMonkey on this.

Comment 12

[Serge Gautherie (:sgautherie)]

MozillaAS v1.7.x is not supported anymore.
The patch has bit rotted: that file doesn't exist (on Trunk) anymore.

(Now is) R.Invalid

Reopen if you can reproduce with a current build.