Closed Bug 291953 Opened 20 years ago Closed 20 years ago

RSS feeds: channel link tag misses http prefix

Categories

(addons.mozilla.org Graveyard :: Public Pages, defect)

Product:
addons.mozilla.org Graveyard
Component:
Public Pages
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Michael.Keppler, Assigned: Bugzilla-alanjstrBugs)

References

(
URL
)

Details

Attachments

(1 file, 4 obsolete files)

Removed extra quote
883 bytes, patch
cso
: first-review+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de-DE; rv:1.7.7) Gecko/20050414 Firefox/1.0.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de-DE; rv:1.7.7) Gecko/20050414 Firefox/1.0.3

The RSS feeds beginning looks like
<rss version="2.0">
<channel>
<title>Mozilla Update::Newest </title>
<link>addons.update.mozilla.org</link>

The link value misses "http://". This leads to a non working link (for the feed
name) in most RSS readers (tested with Sage).

Reproducible: Always

Steps to Reproduce:
1.Open https://addons.update.mozilla.org/rss/?application=firefox&list=newest in
a RSS reader
2.Try navigating to the page linked in the feed.
I wonder if this was ever right
Assignee: nobody → Bugzilla-alanjstrBugs
Status: UNCONFIRMED → NEW
Component: Listings → Web Site
Ever confirmed: true
Target Milestone: 1.0 → 1.1

        Attachment #181925 -
        Flags: first-review?(cst)

    
  
Status: NEW → ASSIGNED

        Attachment #181925 -
        Flags: first-review?(cst) → first-review+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Include web path and use const (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #181925 -
        Attachment is obsolete: true

        Attachment #181928 -
        Flags: first-review+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        with semicolon (obsolete)
        — 
          — Splinter Review
      

    


  
Carrying forward R+

        Attachment #181928 -
        Attachment is obsolete: true

        Attachment #181929 -
        Flags: first-review+

    
    

    
  
You say you included the semi-colon, but you didn't actually include it.

    
    

    
  


  

        Attachment #181929 -
        Attachment is obsolete: true

        Attachment #181986 -
        Flags: first-review+

    
    

    
  


  

        Attachment #181986 -
        Attachment is obsolete: true

        Attachment #181987 -
        Flags: first-review?(colin.ogilvie)

    
    

    
  
Comment on attachment 181987 [details] [diff] [review]
Removed extra quote

This is really carrying the previous review forward, now that Alan's fixed the
issues with the previous patch.

Any reason why we define "$siteurl" then later on, manually construct it again
the inc_rssfeed.php page?

        Attachment #181987 -
        Flags: first-review?(colin.ogilvie) → first-review+

    
    

    
  
Committed.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: