291954 - Installing extension from local file fails if an XUL error page is displayed

Status: RESOLVED WORKSFORME

(Core Graveyard :: Installer: XPInstall Engine, defect)

Description

[Bill Gianopoulos [:WG9s]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050329 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050329 Firefox/1.0+

If you download an extension .xpi file to your hard drive, and have XUL error
pages enabled, if the page currently being displayed is an XUL error page, it is
not possible to install the extension by opening the .xpi file from the File ->
Open File... menu.

Reproducible: Always

Steps to Reproduce:
1.  Download any extension .xpi file adn save it on your hard drive
2.  Go to about:config
3.  Set browser.xul.error_pages.enabled to true
4.  enter http://sometotallybogusurl.com/ in the address bar
5.  Wait for the XUL error page to display
6.  Go to File -> Open File... and slect the file you downloaded in step 1

Actual Results:  
Absolutely nothing.

Expected Results:  
Installed the extension.

Comment 1

[Bill Gianopoulos [:WG9s]]

Reqeusting blocking 1.1.

Not sure if it should block or not because I am not sure what the plans are for
1.1 and enabling XUL error pages by default.  This definitely needs to be fixed
BEFORE XUL error pages are turned on by default.

Comment 2

[Bill Gianopoulos [:WG9s]]

Two things I should mention about this bug.

1. It depends entirely on the fact that the XUL error page is currently being
displayed and not on the fact that the previous page load encountered an error.
 You can see this by loading a page that causes an XUL error page to be
displayed, then crating a new tab and loading any page that actually loads
correctly in that tab.  Then, by switching tabs back and forth, you can see that
the issue of failing to install ONLY occurs when you have the tab displaying the
XUL error page selected.

2.  This failure has nothing to do with the landing of Ben's new EM code.  The
failure also occurs with the build I am runing now (2005032907).

Comment 3

[Bill Gianopoulos [:WG9s]]

Re: my comment #1, would it make sense to create a bug "XUL Error Pages should
be enabled by default", and make bugs like this one block it?

Comment 4

[Przemyslaw Bialik]

(In reply to comment #3)

This would make sense although the bug you want to fill would be rather a
duplicate of already existing Bug 216466 (+blocking-aviary1.1).

Comment 5

[Bill Gianopoulos [:WG9s]]

Changing product to core as I just encountered the same issue in seamonkey.

Comment 6

[Przemyslaw Bialik]

WFM on Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20050926
Firefox/1.6a1

Comment 7

[Bill Gianopoulos [:WG9s]]

WFM now too!

Since I reported it, I am resolving it.