Closed Bug 291981 Opened 19 years ago Closed 19 years ago

Extension Manager incompatible version update is broken - fallout from bug 286034

Categories

(Toolkit :: Add-ons Manager, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

Incompatible extension version update is broken. Patch coming up.
Attached patch patch (obsolete) — Splinter Review
The patch fixes this bug by fixing the following
a typo in that minVersion was specified when it should have been maxVersion
a call to installItemFromFileInternal with the args in the wrong order
not staging the xpi for the INSTALLERROR_INCOMPATIBLE_VERSION case so the code
doesn't flip out the second time through if it is compatible
Assignee: bugs → moz_bugzilla
Status: NEW → ASSIGNED
Attachment #181891 - Flags: review?(bugs)
Depends on: eminstall
Keywords: regression
Isn't this the same as bug 291963?
(In reply to comment #2)
> Isn't this the same as bug 291963?
bug 291963 is for the alert and this is for it not working at all which I didn't
find until later. I could combine the two bugs as well as several others that
are waiting on review though in regards to bug 291963 it is not clear how Ben
was going to handle the alerts with the new code he checked in.
Attachment #181891 - Attachment is obsolete: true
Attachment #181891 - Flags: review?(bugs)
Attached patch patchSplinter Review
This takes care of the alert as well.
Attachment #181900 - Flags: review?(bugs)
*** Bug 291963 has been marked as a duplicate of this bug. ***
Marking fixed.
Fixing this bug has exposed another bug with the process. I am going to test all
scenarios for incompatible version update that I am able to and any other areas
I have time to test and open a new bug for these issues.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: