292022 - RFE - allow multiple requests at once

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, enhancement, P3)

Description

[Jared Warren]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.6) Gecko/20050225 Firefox/1.0.1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.6) Gecko/20050225 Firefox/1.0.1

The "Add CC:" field allows a user to specify a comma-delimited list of strings
to be matched for bugzilla accounts to be added.  The flag requests field only
allows a single entry (not comma delimited).  Would be nice if you could specify
a comma-delimited list of requestees in that field to avoid having to re-submit
changes.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: implements feature

Here's a patch that implements the feature.  You can enter multiple addresses
into a flag's requestee field, and a flag will be created for each address.  If
you do this for an existing request, the existing request will take the first
address (which means it won't change if that address is the existing
requestee), and new requests will be created for each additional address.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Thanks Joel!

Checking in Bugzilla/Flag.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Flag.pm,v  <--  Flag.pm
new revision: 1.50; previous revision: 1.49
done
Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.279; previous revision: 1.278
done
Checking in attachment.cgi;
/cvsroot/mozilla/webtools/bugzilla/attachment.cgi,v  <--  attachment.cgi
new revision: 1.93; previous revision: 1.92
done

Comment 3

[Frédéric Buclin]

My vote to back out this patch! It looks like a big hack and has several issues,
see bug 305771 and bug 305773.

I think existing flags should not accept several requestees; this doesn't make
sense.

Comment 4

[Joel Peshkin]

Ack!  Sounds like it needs to back out unless myk has a quick fix.

Comment 5

[Myk Melez [:myk] [@mykmelez]]

I fixed one regression and am working on a fix for the other.  I see no need to
back this out.  It's not a hack at all.

Comment 6

[Max Kanat-Alexander]

Added to the Bugzilla 2.22 Release Notes in bug 322960.

Comment 7

[Frédéric Buclin]

*** Bug 353755 has been marked as a duplicate of this bug. ***