Closed Bug 292118 Opened 16 years ago Closed 16 years ago

Make transformiix compile for windows ce

Categories

(Core :: XSLT, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: dougt, Assigned: dougt)

Details

Attachments

(1 file, 1 obsolete file)

 
Attached patch ERROR is defined on Windows CE (obsolete) — Splinter Review
Attachment #181983 - Flags: superreview?(dveditz)
Attachment #181983 - Flags: review?(bugmail)
1. ERROR isn't actually *used* by ExprLexer.(h|cpp).
2. eEnum or eENUM is much nicer.

could we possibly change to the style described by 2?
Component: Build Config → XP Toolkit/Widgets: Menus
ERROR does indeed look unused (if you remove it, please update the numbers in
the enum) and I'd be all for chaning constant-style.
I vote for 

-        ERROR = 0,
-        NULL_TOKEN,
+        NULL_TOKEN = 1,

Just to throw in another scheme. Peter?
Component: XP Toolkit/Widgets: Menus → XSLT
Comment on attachment 181983 [details] [diff] [review]
ERROR is defined on Windows CE

I guess we pretty much agree that this is not "it".
Attachment #181983 - Flags: superreview?(dveditz)
Attachment #181983 - Flags: review-
Attachment #181983 - Flags: review+
(In reply to comment #4)
> I vote for 
> 
> -        ERROR = 0,
> -        NULL_TOKEN,
> +        NULL_TOKEN = 1,

I'm fine with this, it's the least invasive.
Attachment #181983 - Attachment is obsolete: true
Attachment #182079 - Flags: review?(peterv)
Comment on attachment 182079 [details] [diff] [review]
patch as suggested.

r=me, requesting sr from peterv
Attachment #182079 - Flags: superreview?(peterv)
Attachment #182079 - Flags: review?(peterv)
Attachment #182079 - Flags: review+
Attachment #182079 - Flags: superreview?(peterv) → superreview+
Checking in extensions/transformiix/source/xpath/ExprLexer.h;
/cvsroot/mozilla/extensions/transformiix/source/xpath/ExprLexer.h,v  <-- 
ExprLexer.h
new revision: 1.20; previous revision: 1.19
done

Asa gave permission to a 291229 which included this patch.
Thanks.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.