292179 - [Mac] Keyboard short cut for help window does not open the help window correctly

Status: RESOLVED DUPLICATE of bug 295337

(Firefox :: Keyboard Navigation, defect)

Description

[philippe (part-time)]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050428 Firefox/1.0+  (phiw13)
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050428 Firefox/1.0+  (phiw13)

When starting up the browser, the keyboard shortcut (command - ?) does not open
the help window fully. The right pane remains empty.
Javascript Console reports
'Help file:  was not found.'
'TypeError: datasource has no properties'.

This happens since the landing of bug 253693.

Manually going to the 'Help' menu and opening the help window from there does
open the help window correctly.

Additionally, at startup, trying to access the 'Text Size' > Increase shortcut
also opens the help window with the same errors in the console. Manually going
to the menu item, then using the keyboard shortcut fixes this problem. (see also
bug 273208 for this).

This happens with OS X 10.3.9, with a Shift-JIS keyboard. To access both
keyboard shorcuts, I need to add the 'shift' modifier.

Tested with both my own build (basically just optimized) and the official
nightly builds (when available)

Reproducible: Always

Steps to Reproduce:
1.Start up the browser, optionally load a web page.
2.Use the keyboard (command-shift-?) to access the help window.

Actual Results:  
Help window only partially loaded.

Expected Results:  
Window should be fully loaded. Only the command-? (or command-shift-? for my
keyboard mapping) should access the 'help window'.

Comment 1

[Ben Fowler]

(In reply to comment #0)
> When starting up the browser, the keyboard shortcut (command - ?) does not 
> open the help window fully. The right pane remains empty.
> Javascript Console reports
> 'Help file:  was not found.'
> 'TypeError: datasource has no properties'.
> 
> This happens since the landing of bug 253693.
> 
> Manually going to the 'Help' menu and opening the help window from there does
> open the help window correctly.

My lizard was compiled about 6 hours ago. OS X 10.2.8

I find that with a UK keyboard, Cmd-/ does not open the help window, but
Cmd-Shift-/ does. (In my view this a bug). I don't get errors in the 
Javascript console.

Both Cmd-= and Cmd-Shift-= increase text size, and both Cmd-- and Cmd-Shift--
(minus and underscore) decrease it.

You may be reporting more than one bug. Are all the features in your report
reproducible in an official nightly? Are you able to check that none of
your .xul and .js files contains conflict markers?

I am not sure when your help window is fully loaded, and when only the left
side. 

Comment 2

[philippe (part-time)]

(In reply to comment #1)
> 
> I find that with a UK keyboard, Cmd-/ does not open the help window, but
> Cmd-Shift-/ does. (In my view this a bug). I don't get errors in the 
> Javascript console.

Command-Shift -/ is mapped to the question mark on my Japanese shift_jis
keyboard (stock Apple , PowerBook G4 1.5Ghz). Command - / doesn't do anything on
my side.

> 
> Both Cmd-= and Cmd-Shift-= increase text size, and both Cmd-- and Cmd-Shift--
> (minus and underscore) decrease it.

Same here for both Cmd-- and Cmd-Shift--. I've no problems with this one. The
text-size, increase is problematic on my side. See my bug 273208 for this
> 
> You may be reporting more than one bug. Are all the features in your report
> reproducible in an official nightly?
Yes, I checked with the 0427 official nightly. It is possible that there are 2
bugs acting up here

> Are you able to check that none of
> your .xul and .js files contains conflict markers?

How do I do that ? My build is pretty much a stock build fetched from CVS, same
as described by Kai in this forum thread.
http://forums.mozillazine.org/viewtopic.php?t=149532

> 
> I am not sure when your help window is fully loaded, and when only the left
> side. 

I'll attach a screenshot next of what the help window looks like at startup.

Comment 3

[philippe (part-time)]

Attachment: Help window at start up

Comment 4

[Ben Fowler]

(In reply to comment #2)
> (In reply to comment #1)
> > Are you able to check that none of
> > your .xul and .js files contains conflict markers?
> 
> How do I do that ? My build is pretty much a stock build fetched from CVS, same
> as described by Kai in this forum thread. ...

Use a command like: 
[tit002:~] bfowler% find . -type f -exec grep -Hl '^=======$' {} \;
grep: ./.qt/.qt_plugins_3.1rc.lock: Permission denied
./Applications/Debug/Firefox.2005-04-19.app/Contents/MacOS/components/nsProxyAutoConfig.js
./Library/Application Support/Firefox/Profiles/9iegeezi.Fourth
User/Cache/2F8D8D58d01
./Library/Application Support/Firefox/Profiles/9iegeezi.Fourth
User/Cache/_CACHE_003_
./Library/Thunderbird/Profiles/hi8s0i4o.default/Mail/Local Folders/Lists
grep: ./Sites/admin/repchase.php: Permission denied

Comment 5

[philippe (part-time)]

(In reply to comment #4)

[04/28-21:38][pi-kun:~]
  $ find . -type f -exec grep -Hl '^=======$' {} \;
find: ./.cpan/build/Config-General-2.27: Permission denied
find: ./.Trashes: Permission denied
./Library/Mail/Mailboxes/CSS-D_03_2005.mbox/mbox
./Library/Mail/Mailboxes/WD/WD_list_2004_01-05.mbox/mbox
./Library/Mail/Mailboxes/www-style/www-style_2004/10October2004.mbox/mbox
./mozilla/directory/c-sdk/ldap/libraries/libldap/fdsetsize.txt
./mozilla/gfx/cairo/cairo/NEWS
./mozilla/intl/unicharutil/tools/UCDATAREADME.txt
./mozilla/security/nss/lib/freebl/ecl/README
./mozilla/security/nss/lib/freebl/ecl/README.FP

Anyway, I put the official 04/27 nightly [1] on the kid's iBook (which has never
had Firefox installed, and runs with login language Japanese). I had exactly the
same problem(s).

[1] taken from
ftp://ftp.mozilla-japan.org/pub/mozilla.org/firefox/nightly/2005-04-27-08-trunk/
Didn't find any Japanese localised build.

Comment 6

[philippe (part-time)]

The patch for bug 295337 has fixed the problem I described here.

Comment 7

[Asaf Romano (gone)]

The later has fixed it.

*** This bug has been marked as a duplicate of 295337 ***