292222 - Crash on some SVG with no gdi+ [@ nsStyleContext::GetStyleData]

Status: VERIFIED FIXED

(Core :: SVG, defect)

Description

[Hubert Gajewski]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050427 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050427 Firefox/1.0+

Mozilla crashes every time when I open this page:
http://orwellstat.hubertgajewski.com/stats/
I use SVG-build, svg.enabled: true.

TBid: 5422250

Reproducible: Always

Steps to Reproduce:
1. Go to http://orwellstat.hubertgajewski.com/stats/
2. Wait
3. Crash

Comment 1

[Hermann Schwab]

gdiplus.dll installed:
wfm Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b2) Gecko/20050430 Firefox/1.0+
wfm Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b2) Gecko/20050430

gdiplus.dll not installed:
crash Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b2) Gecko/20050430 Firefox/1.0+
wfm Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b2) Gecko/20050430

also crashing on http://www.croczilla.com/svg/samples/svgtetris/svgtetris.svg

TalkbackIDs: TB5478573Y, TB5478018M, TB5476502Z
http://talkback-public.mozilla.org/talkback/fastfind.jsp?search=2&type=iid&id=TB5478573Y
http://talkback-public.mozilla.org/talkback/fastfind.jsp?search=2&type=iid&id=TB5478018M

identical Talkbacks for different sites

see http://www.mozilla.org/projects/svg/gdiplus/ for info and download link,
and install according to Redist.txt in the download:

For Windows 2000, Windows Millennium Edition, Windows NT 4.0 and Windows 98,
install gdiplus.dll into the private directory of the application not into the
system directory. 

I didn´t succeed using the system32 folder as suggested somewhere.

Comment 2

[Taral]

WFM on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050428
Firefox/1.0+ (Windows XP).

Win2k specific?

Comment 3

[Hermann Schwab]

(In reply to comment #2)
> WFM on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050428
> Firefox/1.0+ (Windows XP).
> 
> Win2k specific?

did you read comment #1?

CRASH Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b2) Gecko/20050430 Firefox/1.0+ 

CRASHING when gdiplus.dll NOT installed.
WindowsXP supplies gdiplus.dll, for older windows you´ve got to download it.

This crash happens on Firefox only, as Firefox supports svg.
Though Mozilla suite also comes with svg.enabled true, svg isn´t working, but
also don´t crash.

My recommendation:
reset svg.enabled default to disabled, as long as missing gdiplus.dll leads to
crash. This should be default for Win9x, WinNT, Win2k.

Comment 4

[tor]

Attachment: allow nsSVGGlyphFrame::Init to complete to SetStyleContext when no renderer

Comment 5

[Alex Fritze]

Comment on attachment 182516 [details] [diff] [review]
allow nsSVGGlyphFrame::Init to complete to SetStyleContext when no renderer

If bailing before SetStyleContext() leads to a crash, shouldn't we also move
the mMetrics/mGeometry checks?
->
if (!render || !mMetrics || !mGeometry) {...}

Comment 6

[tor]

Attachment: Good point

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 182527 [details] [diff] [review]
Good point

a=asa

Comment 8

[tor]

Checked in.

Comment 9

[Hubert Gajewski]

VERIFIED FIXED with Deer Park Alpha 1 on Windows 2000.