292269 - document the new "Options" button on the blocked popup info bar

Status: RESOLVED FIXED

(Firefox Graveyard :: Help Documentation, defect)

Description

[Steffen Wilberg]

Bug 220626 introduced an Options button to the blocked popup info bar.

Comment 1

[Steffen Wilberg]

Attachment: patch

Document the button, and improve the description of the popup options menu.

Comment 2

[Jeff Walden (gone starting June 8)]

Comment on attachment 182317 [details] [diff] [review]
patch

>-  <li>Edit <a href="#popup_blocker_preferences">Popup Blocker Options</a></li>
>-  <li>Don't show info message when blocking popups</li>
>+  <li>Edit <a href="#popup_blocker_preferences">Popup Blocker &pref.pluralCaps;...</a></li>

This change (to using the prefs entity) is actually incorrect, as it seems the
text isn't OS-specific.  The only difference is that the message has three
periods at the end of it.  I filed bug 293523 and provided the patch to get the
platform-specific string issue fixed, but for now we should just add three
periods to the end of the string and otherwise leave it alone.

>+  <li>Don't show this message (the information bar) when blocking popups</li>

Change "(the information bar)" to "(info message)", as at least in Linux that's
what I'm seeing as the result of hitting the status bar button.  Also, change
"blocking popups" to "when popups are blocked".

These are trivial changes, so just make sure to fix them before you check in
the patch.  Requesting approval for checkin...

Comment 3

[Asa Dotzler [:asa]]

Comment on attachment 182317 [details] [diff] [review]
patch

a=asa

Comment 4

[Steffen Wilberg]

Fixed, with comments addressed.

Checking in mozilla/browser/locales/en-US/chrome/help/popup.xhtml;
/cvsroot/mozilla/browser/locales/en-US/chrome/help/popup.xhtml,v  <--  popup.xhtml
new revision: 1.12; previous revision: 1.11
done