292270 - Venkman does not load scripts view

Status: RESOLVED INVALID

(Other Applications Graveyard :: Venkman JS Debugger, defect)

Description

[Peter Wilson]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050427 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050427 Firefox/1.0+

Javascript Debugger 0.9.84

Error: colID.match is not a function
Source File: chrome://venkman/content/tree-utils.js
Line: 1463

BasicOView.prototype.getCellText =
function bov_getcelltxt (row, colID)
{
    if (!this.columnNames)
        return "";
    
    var ary = colID.match (/:(.*)/);
    if (ary)
        colID = ary[1];

    var col = this.columnNames[colID];
    
    if (typeof col == "undefined")
        return "";
    
    return this.data[row][col];
}

The idl for this function is   

AString getCellText(in long row, in nsITreeColumn col);

The code seems to be expecting a string.

Reproducible: Always

Comment 1

[Peter Wilson]

Attachment: Screen shot of Venkman showing missing script views.

Comment 2

[James Ross]

Sorry, you're using a known incompatible build. See
http://www.hacksrus.com/~ginda/venkman/ and get 0.9.85.

Comment 3

[Peter Wilson]

Attachment: Fixed getCellText x 2 and obsolete use of this.tree.selection

Also 
getCellText @Line 267.
General use of this.tree.selection
This has changed to this.tree.view.selection

I will include a fixed version of tree-utils.js which works on the above build.

Comment 4

[James Ross]

Not only have you 'fixed' it so that it would no longer work on Mozilla 1.7/FF
1.0 and earlier, but we've already done this work (and better, as it works on
1.7/1.0 and earlier too) for Venkman 0.9.85.