Closed
Bug 292300
Opened 20 years ago
Closed 20 years ago
Remove SubstValueForCode()
Categories
(Core :: Printing: Output, defect)
Core
Printing: Output
Tracking
()
VERIFIED
FIXED
People
(Reporter: smontagu, Assigned: smontagu)
Details
Attachments
(1 file)
|
2.43 KB,
patch
|
roc
:
review+
roc
:
superreview+
asa
:
approval1.8b2-
shaver
:
approval1.8b3+
|
Details | Diff | Splinter Review |
With the checkin for bug 272386, nsPageFrame::RemoveSubstValueForCode() has no
callers. It should die.
|
Assignee | |
Comment 1•20 years ago
|
||
Attachment #182145 -
Flags: superreview?(roc)
Attachment #182145 -
Flags: review?(roc)
Attachment #182145 -
Flags: superreview?(roc)
Attachment #182145 -
Flags: superreview+
Attachment #182145 -
Flags: review?(roc)
Attachment #182145 -
Flags: review+
|
|
Assignee | |
Comment 2•20 years ago
|
||
Comment on attachment 182145 [details] [diff] [review]
Patch
Please approve this patch (removal of unused code).
Attachment #182145 -
Flags: approval1.8b2?
|
||
Comment 3•20 years ago
|
||
Comment on attachment 182145 [details] [diff] [review]
Patch
moving request out to b3. We're very nearly wrapped up on 1.8b2.
Attachment #182145 -
Flags: approval1.8b3?
Attachment #182145 -
Flags: approval1.8b2?
Attachment #182145 -
Flags: approval1.8b2-
|
||
Comment 4•20 years ago
|
||
Comment on attachment 182145 [details] [diff] [review]
Patch
a=shaver
Attachment #182145 -
Flags: approval1.8b3? → approval1.8b3+
|
||
Comment 5•20 years ago
|
||
Simon: this landed Did you mean to mark this fixed? Or are there other trees
to check-in to?
|
|
Assignee | |
Comment 6•20 years ago
|
||
Thanks for the reminder :)
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
|
||
Comment 7•20 years ago
|
||
Verified FIXED: code is removed:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/layout/generic&command=DIFF_FRAMESET&file=nsPageFrame.cpp&rev1=3.143&rev2=3.144&root=/cvsroot
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•