292351 - Use unified title/toolbar window

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Manfred Schubert]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050428 Camino/0.8+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050428 Camino/0.8+

Switch to unified title/toolbar window for the browser window. Then make the
bookmarks bar in gray (a little bit darker than now) without stripes to match
better the title/toolbar area.

Unified title/toolbar looks very cool in Camino as can be seen by the attached
screenshot.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Manfred Schubert]

Attachment: Unified title/toolbar look of Camino browser window

Comment 2

[Mike Pinkerton (not reading bugmail)]

it does look cool. is this easy to do on tiger and have it still work fine on
jag/panther?

we should investigate this at least, i'm not saying we're doing this  for sure.

Comment 3

[Manfred Schubert]

This is just a button in Interface Builder. Works fine still in Panther for me (there with the old toolbar 
look of course). I can't test Jaguar.

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

This was WONTFIXed as bug 287141 last month.

To me the new style looks too heavy and awkward, but I'm not a UI designer :-)

Comment 5

[Samuel Sidler (old account; do not CC)]

I admit, looking at it now, it doesn't look bad. However, the bookmark toolbar
looks... weird now. I'm sure the tab and status bar would also look off. If
we're going to do this, we need to update them as well, otherwise it won't look
good at all. If we can't change the rest without breaking 10.2 and/or 10.3, I'd
suggest (again) WONTFIX and we re-evaluate this when 10.6 comes out and we've
dropped 10.3 support. :)

Comment 6

[Jasper]

I have been running the unified toolbar pref for a day or two now and I think it
looks awesome in Camino, even considering the fact that the tab bar and
bookmarks bar have another look.

The main good thing about it is that it unclutters the top of the window, one of
the things that I really like about the safari "toolbar metal" implementation.
This is really something to consider for our Tiger users.

I'm already thinking of perhaps making a special tab theme to fit better with
the unified toolbar.

Comment 7

[Prachi Gauriar]

Codewise, it seems like you just need to do something like: 

if ([toolbar respondsToSelector:@selector(setShowsBaselineSeparator:) {
    [toolbar setShowsBaselineSeparator:NO];
}

<http://developer.apple.com/documentation/Cocoa/Reference/ApplicationKit/ObjC_classic/Classes/
NSToolbar.html#//apple_ref/doc/uid/20000681-BCIIDCAH>

This may be a better for compatibility than using IB, but I'm not really sure.  I don't even have Tiger yet. 
:-( 

Comment 8

[Jamie Diamond]

*** Bug 287141 has been marked as a duplicate of this bug. ***

Comment 9

[L. H.]

Fixed in 20050521