292357 - nsFrameLoader uses incorrect base URI

Status: RESOLVED FIXED

(Core :: Layout: Images, Video, and HTML Frames, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

112   nsIURI *base_uri = doc->GetBaseURI();

Instead, that URI should be gotten off mOwnerContent directly, as each node can
have a different base.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

(ie., mOwnerContent->GetBaseURI())

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: testcase

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 182209 [details] [diff] [review]
patch

low risk patch to use the correct base URI for frames

Comment 5

[Asa Dotzler [:asa]]

Comment on attachment 182209 [details] [diff] [review]
patch

a=asa

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in content/base/public/nsIContent.h;
/cvsroot/mozilla/content/base/public/nsIContent.h,v  <--  nsIContent.h
new revision: 3.108; previous revision: 3.107
done
Checking in content/base/src/nsFrameLoader.cpp;
/cvsroot/mozilla/content/base/src/nsFrameLoader.cpp,v  <--  nsFrameLoader.cpp
new revision: 1.53; previous revision: 1.52
done