292384 - AddKeywordForSearchField errors on FIELDSET items

Status: RESOLVED DUPLICATE of bug 283719

(Firefox :: Bookmarks & History, defect)

Description

[Conrad Carlen (not reading bugmail)]

1. Try using "Add Keyword for this Search..." on the bugzilla query page
2. Nothing happens

The problem is this code:
http://lxr.mozilla.org/seamonkey/source/browser/base/content/browser.js#5489
FIELDSET elements done have a "type" property, so an exception is thrown.

According to this:
http://www.w3.org/TR/REC-html40/interact/forms.html#successful-controls
a "successful control" has to have a name attribute. FIELDSETs don't.

Adding:
if (!("name" in e))
  continue;
to both loops seems to work.

Question is: Are children of the FIELDSET included in the form.elements array?
By observation, they seem to be - FIELDSETS don't need to be descended into (?).
Somebody knowing more about from processing should confirm. If that's right,
I'll submit a patch.

Also, this code doesn't do the right thing with lists containing a multiple
selection.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

*** This bug has been marked as a duplicate of 283719 ***