292392 - JS_VERSION=110 doesn't build - jsinterp.c(2889) : error C2106: '=' : left operand must be l-value

Status: RESOLVED WONTFIX

(Core :: JavaScript Engine, defect, P5)

Description

[timeless]

#if JS_BUG_EAGER_TOSTRING
#define CHECK_EAGER_TOSTRING(hint)  (hint = JSTYPE_STRING)
...
#endif

#define VALUE_TO_PRIMITIVE(cx, v, hint, vp)                                   \
    JS_BEGIN_MACRO                                                            \
        if (JSVAL_IS_PRIMITIVE(v)) {                                          \
            CHECK_VOID_TOSTRING(cx, v);                                       \
            *vp = v;                                                          \
        } else {                                                              \
            SAVE_SP(fp);                                                      \
            CHECK_EAGER_TOSTRING(hint);                                       \

#define RELATIONAL_OP(OP)                                                     \
...
            VALUE_TO_PRIMITIVE(cx, lval, JSTYPE_NUMBER, &lval);               \
            VALUE_TO_PRIMITIVE(cx, rval, JSTYPE_NUMBER, &rval);               \

#define EQUALITY_OP(OP, IFNAN)                                                \
...
        if (ltmp == rtmp) {                                                   \
...
        } else {                                                              \
            if (JSVAL_IS_NULL(lval) || JSVAL_IS_VOID(lval)) {                 \
...
            } else if (JSVAL_IS_NULL(rval) || JSVAL_IS_VOID(rval)) {          \
...
            } else {                                                          \
                if (ltmp == JSVAL_OBJECT) {                                   \
                    VALUE_TO_PRIMITIVE(cx, lval, JSTYPE_VOID, &lval);         \
...
                } else if (rtmp == JSVAL_OBJECT) {                            \
                    VALUE_TO_PRIMITIVE(cx, rval, JSTYPE_VOID, &rval);         \
...

          case JSOP_EQ:
            EQUALITY_OP(==, JS_FALSE);
...

          case JSOP_NE:
            EQUALITY_OP(!=, JS_TRUE);

cl -FoWINNT5.1_DBG.OBJ/ -c /MD /Od /Z7  -D_X86_=1 -DXP_WIN -DXP_WIN32 -DWIN32
-D_WINDOWS -D_WIN32 /nologo /W3 /FpWINNT5.1_DBG.OBJ/js.pch  -DDEBUG
-DDEBUG_timeless -DJS_VERSION=110   /Op -DEXPORT_JS_API jsinterp.c
jsinterp.c
jsinterp.c(2889) : error C2106: '=' : left operand must be l-value
jsinterp.c(2889) : error C2106: '=' : left operand must be l-value
jsinterp.c(2893) : error C2106: '=' : left operand must be l-value
jsinterp.c(2893) : error C2106: '=' : left operand must be l-value
jsinterp.c(2941) : error C2106: '=' : left operand must be l-value
jsinterp.c(2941) : error C2106: '=' : left operand must be l-value
jsinterp.c(2945) : error C2106: '=' : left operand must be l-value
jsinterp.c(2945) : error C2106: '=' : left operand must be l-value
jsinterp.c(2949) : error C2106: '=' : left operand must be l-value
jsinterp.c(2949) : error C2106: '=' : left operand must be l-value
jsinterp.c(2953) : error C2106: '=' : left operand must be l-value
jsinterp.c(2953) : error C2106: '=' : left operand must be l-value
jsinterp.c(3003) : error C2106: '=' : left operand must be l-value
jsinterp.c(3004) : error C2106: '=' : left operand must be l-value
make[1]: *** [WINNT5.1_DBG.OBJ/jsinterp.obj] Error 2

Comment 1

[timeless]

afaik this traces to:

3.2 <fur> 1998-04-23 17:30
Initial checkin of JavaScript 1.3, migrated from JSFUN13_BRANCH in /m/src repository

I don't have access to that repository, i can try to rebuild this based on 3.1,
but it'll take me some time. i'll have 1.2-1.4 working today.

Comment 2

[Brendan Eich [:brendan]]

I'd rather just lose JS_BUG_EAGER_TOSTRING, and maybe even all the JS_BUG_
config macros.  Who cares?

Maybe we should gut jsconfig.h too, keeping only the ECMA and current (and
current - 1, perhaps) versions.

/be

Comment 3

[Bob Clary [:bc] (inactive)]

marking testcase-, but ideally we would have a place for compile tests.