292428 - Make automatic away checking not suck

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Description

[James Ross]

There are a few issues with the auto-away (WHO) checking currently, which I'd
like to solve.

  - It seems to be causing user PrefManagers into existence when not needed.
  - It considers all channels to be on the same network.
  - Its delay is not configurable.
  - Its replies use the main event queue, potentially lagging the client.

Comment 1

[James Ross]

Attachment: [checked-in] Don't delete the property

This fixes my first point in comment 0.

Just to note that a) this shouldn't have been done in the first place, and b) I
have NO idea why this caused it to break here!

Comment 2

[Asa Dotzler [:asa]]

Comment on attachment 182259 [details] [diff] [review]
[checked-in] Don't delete the property

a=asa

Comment 3

[:Gijs (he/him)]

Taking...

Comment 4

[:Gijs (he/him)]

Attachment: Patch

Patch that (hopefully) fixes all the stuff.

Comment 5

[James Ross]

Comment on attachment 214040 [details] [diff] [review]
Patch

>+        if (net.lastWhoCheckChannel)
>+        {
>+            net.lastWhoCheckChannel = null;
>+            checkWho();
>         }
>     }

Weird scoping usage. :) Also, nit: missing semi-colon after inner function.

> 
>-    if (lastWhoCheckChannel)
>+    client.display(String(new Date()) + " onWhoTimeout fired.");

Nit: remove this line.

>+    for (var n in client.networks)

r=silver with that nit fixed.

Comment 6

[James Ross]

Checked in --> FIXED